I think there should be separate permissions for accessing site-wide XML sitemap settings—which only highly-privileged users should touch, I would think—and changing an individual node's settings from its node edit page—which content editors commonly need to do. Just because someone needs to be able to change the inclusion settings for their own nodes doesn't mean they should be able to add a new sitemap, update cached files, or change search engine submission settings. "Administer XML sitemap settings" seems like appropriate language for the site-wide configuration. I would add something like "Edit node inclusion settings".

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Anonymous’s picture

Status: Active » Postponed (maintainer needs more info)

Can't this be accomplished with a custom module using hooks?

TravisCarden’s picture

Status: Postponed (maintainer needs more info) » Active

Doubtless it can—as can most anything—but is that the important question? It seems to me the separation of administrative from editorial permissions is essential for any module designed for general application and that only uncommon functionality should require custom development. (After all, not all Drupal users are developers.) I propose that the cost of adding a second permission is not comparable to the benefit of having it. A quick perusal of the issue queue suggests that other users are looking for more granular permissions, too. Do you have a specific objection to obliging them?

Anonymous’s picture

Status: Active » Postponed

Ok, but postponed until a first release.

ruudvanoijen’s picture

Issue summary: View changes
Status: Postponed » Needs review
FileSize
5.44 KB

I've created a patch for this. To have 3 permissions. One for advanced settings, one for managing xml sitemap. One for adding content to the xml sitemap.

Status: Needs review » Needs work

The last submitted patch, 4: seperate_permissions_xmlsitemap-1440216-4.patch, failed testing.

ralphvdhoudt’s picture

Better patch

brockfanning’s picture

Status: Needs work » Needs review
FileSize
4.36 KB

Trying a re-roll to work with the latest dev.

Status: Needs review » Needs work

The last submitted patch, 7: seperate_permissions_xmlsitemap-1440216-7.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

paulvandenburg’s picture

Confirmed working reroll of the patch. Sadly interdiff is having difficulty computing a proper interdiff between 5 (#6) and #7.

But perhaps we should fix the failing tests before marking this RTBC.