Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.On the activity streams like user activity, there is no space between the message and the time.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | heartbeat_space_and_time.png | 21.06 KB | Stalski |
| #1 | heartbeat-time_padding-1432344-1.patch | 286 bytes | rooby |
Comments
Comment #1
rooby CreditAttribution: rooby commentedHere is a patch to fix it.
Comment #2
Stalski CreditAttribution: Stalski commentedSorry, but I will reject this patch.
In the screenshot attached, you'll see how it works with display suite and the default layout of heartbeat. I just can't break any consistency for other people.
It's very easy to add this css in your theme css. That's the purpose. Heartbeat (and heartbeat_defaults) only provides default behavior and visualisation. But it's for drupalistas to add their own css overrides.
Thx for the patch though
Comment #3
rooby CreditAttribution: rooby commentedBut I am using the drupal core seven admin theme. How can you not support drupal core?
There should be separate css for display suite as not everyone will be using it.
More assumptions :(
I know I can override the themeing but I am using a drupal core admin theme specifically so I won't have as many compatibility problems with modules & theme. I would normally expect things to work out of the box with drupal core.
Changing status so you don't miss the reply. I don't mind if you mark it won't fix again though.
Comment #4
Stalski CreditAttribution: Stalski commentedAre you suggesting that contrib modules must have css that is compatible and "nice" with all themes in core? I did not test things in a theme and I did not now I needed to care about certain themes.
The assumption that heartbeat takes is to have default theming that is "none".
When enabling display suite you get the heartbeat activity layout for free (meaning avatar left, message right, comments at the bottom). So this is not theming actually.
conclusion, if you don't use Display Suite, then you have to theme things yourself.
The only remark I totally agree with is that heartbeat makes assumptions to theming, as there is a default heartbeat.css file. So to improve this I can only remove that file, but then you have nothing out of the box (like in drupal 6 version) and there was a lot complaining about that, where now people seem (generally ;) ) happy