Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1310084: [meta] API documentation cleanup sprint
This is for the system module, subdirectory tests, files and sub-directories in there starting with J through Z, including the themes
and upgrade
subdirectories.
Comment | File | Size | Author |
---|---|---|---|
#10 | system_tests_j_z-1431664-10.patch | 11.89 KB | Albert Volkman |
#10 | interdiff.txt | 2.75 KB | Albert Volkman |
#8 | system_tests_j_z-1431664-8.patch | 11.4 KB | Albert Volkman |
#8 | interdiff.txt | 643 bytes | Albert Volkman |
#7 | system_tests_j_z-1431664-7.patch | 11.39 KB | Albert Volkman |
Comments
Comment #1
xjmComment #2
xjmUpdating scope for #1299424: Allow one module per directory and move system tests to core/modules/system.
Comment #2.0
xjmAdded explicit mention of subdirs
Comment #3
mmartinov CreditAttribution: mmartinov commentedI'm taking this, I should be able to post a patch soon.
Comment #4
Albert Volkman CreditAttribution: Albert Volkman commentedHere's a first rough patch.
Comment #5
jhodgdonThanks!
The standard for menu callbacks is:
http://drupal.org/node/1354#menu-callback
- You need : instead of ;
- The next thing should be a verb like "Records the active trail for 403/404 pages" rather than "Used for ..."
So, most of this patch needs an update.
Comment #6
Albert Volkman CreditAttribution: Albert Volkman commentedThis patch resolves the semicolon versus colon mixup. Next up is fixing the verbiage.
Comment #7
Albert Volkman CreditAttribution: Albert Volkman commentedRe-roll of #6.
Comment #8
Albert Volkman CreditAttribution: Albert Volkman commentedFixed incorrect docblock for
system_test_basic_auth_page()
.Comment #9
jhodgdonThanks, looking better!
These do not follow our standards for hook_menu callbacks:
https://drupal.org/node/1354#menu-callback
They need a verb. There are 4 in this file that need updating, one in session_test.module, and a couple in theme_test.module.
Other than that, the patch looks pretty good... Oh, here's another problem, in session_test.module:
"with after"? This doesn't quite make sense. :)
And can we fix the typo here:
Comment #10
Albert Volkman CreditAttribution: Albert Volkman commentedGive this a try.
Comment #11
Albert Volkman CreditAttribution: Albert Volkman commentedComment #11.0
Albert Volkman CreditAttribution: Albert Volkman commented.
Comment #12
jhodgdonThese issues are a lot of work with very little tangible payoff, so I'm closing the rest of them as "won't fix". Your efforts on working on this issue were appreciated... it was just my fault for starting a task that was very difficult to get right.
Let's instead put our effort into fixing and reviewing documentation that is really unclear and/or wrong, and I hope that the people who worked on these issues are not afraid to jump into a more reasonable issue!