oauth_common_form_consumer_delete() incorrect [#1431642]

oauth_common_form_consumer_delete() is declared as

function oauth_common_form_consumer_delete($form_state, $consumer) {

when it should be declared as

function oauth_common_form_consumer_delete($form, $form_state, $consumer) {

This causes the delete to fail since $consumer is incorrectly set.

Comment	File	Size	Author
#8	oauth-1431642-consumer-deletion.patch	515 bytes	kotnik
#8

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

stevesmename CreditAttribution: stevesmename commented 7 February 2012 at 17:37

Call to a member function delete() on a non-object in oauth_common.consumers.inc on line 255

I believe the error above is regarding this issue. I'm unable to delete an application.

Comment #2

nevets CreditAttribution: nevets commented 7 February 2012 at 18:35

Yes, this bug is the cause of that error.

Comment #3

jobeirne CreditAttribution: jobeirne commented 8 February 2012 at 18:57

Good catch, nevets, though `$form_state` should be `&$form_state`. Committing now.

Comment #4

jobeirne CreditAttribution: jobeirne commented 8 February 2012 at 19:01

Status:

Active

» Closed (fixed)

Comment #5

Alex Andrascu CreditAttribution: Alex Andrascu commented 13 February 2012 at 16:28

Status:

Closed (fixed)

» Fixed

Leave it open for a while until you either release a stable "stable" version or until it closes by itself (2 weeks), so people can still find the fix. Was just going to abandon all hopes until I thought to give closed a try.

Thanks.

Comment #6

27 February 2012 at 16:30

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Comment #7

muka CreditAttribution: muka commented 10 April 2012 at 12:09

Hi, I reopen this because I got the same problem.

Call to a member function delete() on a non-object in oauth_common.consumers.inc on line 255

oaut_common.consumer.inc, line252

function oauth_common_form_consumer_delete_submit($form, &$form_state) {
-  $consumer = $form_state['values']['consumer_object'];
+  $consumer = $form_state['build_info']['args'][0];