If D7 has been installed using the "minimal" profile, the "Full HTML" text format will not be created.

The module attempts to use check_markup() on the title and description fields with $format_id = 'full_html' which results in an empty string being returned and thus, no titles or descriptions are displayed in the gallery.

This is probably going to confuse a lot of people who are setting up their views correctly but have missing titles and descriptions.

CommentFileSizeAuthor
#6 views_galleriffic-text_filter-1431116-6.patch1.3 KBm.stenta
#3 views_galleriffic-text_filter_1.1-1431116-3.patch1.4 KBm.stenta
#1 views_galleriffic-text_filter-1431116.patch1.4 KBmorbiD
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

morbiD’s picture

morbiD CreditAttribution: morbiD commented
FileSize
views_galleriffic-text_filter-1431116.patch1.4 KB

Attached patch is a quick fix that sets check_markup() to use the default text format instead of trying to force the use of full_html.

However, there should probably be an option in the view settings to choose a text format for each field.

gmclelland’s picture

gmclelland CreditAttribution: gmclelland commented

good catch. I couldn't figure out why my titles and descriptions weren't showing. Patch worked for me.

m.stenta’s picture

m.stenta
he/him
Primary language English
CreditAttribution: m.stenta commented
Status: Active » Reviewed & tested by the community
FileSize
views_galleriffic-text_filter_1.1-1431116-3.patch1.4 KB

Thanks -morbiD-... I was having the same issue (on a site with no Full HTML text format).

Patch in #1 worked great!

I also attached a patch against the current stable release (7.x-1.1) for anyone who needs it (ie: for use with Drush Make).

Changing this to RTBC... commit away!

m.stenta’s picture

m.stenta
he/him
Primary language English
CreditAttribution: m.stenta commented

EXTRA NOTE: Do not apply the patch in #3 to the dev release. It is made for the 7.x-1.1 stable release. Sorry for any confusion.

morbiD’s picture

morbiD CreditAttribution: morbiD commented

Just a minor note on the patch in #3: The last parameter name in check_markup() changed from $check to $cache between D6 and D7. You might want to correct that as I did in my patch.

m.stenta’s picture

m.stenta
he/him
Primary language English
CreditAttribution: m.stenta commented
Status: Reviewed & tested by the community » Needs review
FileSize
views_galleriffic-text_filter-1431116-6.patch1.3 KB

Upon further reflection... the check_markup() function is not necessary at all. Attached is a patch which removes it entirely.

Views already applies the necessary filtering to it before it gets to Views Gallerriffic. So an extra check_markup() doesn't have any benefit.

And, the previous patch (in #1 and #3) was assuming that it would fall back on the "default" text format, which is not true. Instead, it falls back on the "filter fallback format", which by default escapes all HTML tags. See: http://api.drupal.org/api/drupal/modules%21filter%21filter.module/functi... (this is called in the second line of the check_markup() function).

alumni’s picture

alumni CreditAttribution: alumni commented

Fix #1 #6 Works great for me. Thanks