Instead of just passing settings.colorbox.colorbox = false, removing the settings is much cleaner.

CommentFileSizeAuthor
#1 fullcalendar-1429466-1.patch930 bytestim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Assigned: Unassigned » aspilicious
Status: Active » Needs review
FileSize
fullcalendar-1429466-1.patch930 bytes
aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

If you unset colorbox. Can you test for it in the js files like we do now?

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented

In colorbox, we used to test for settings.colorbox.colorbox = false, but now we just check to see if settings.colorbox exists.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Assigned: aspilicious » Unassigned
Status: Reviewed & tested by the community » Fixed

http://drupalcode.org/project/fullcalendar.git/commit/e80d324

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.