Documentation for corporateclean_breadcrumb() is out of date [#1429206]

This function does not accept the breadcrumb parameter.

/**
 * Return a themed breadcrumb trail.
 *
 * @param $breadcrumb
 *   An array containing the breadcrumb links.
 * @return
 *   A string containing the breadcrumb output.
 */
function corporateclean_breadcrumb($variables){
  $breadcrumb = $variables['breadcrumb'];
  if (!empty($breadcrumb)) {
    $breadcrumb[] = drupal_get_title();
    return '<div class="breadcrumb">' . implode(' <span class="breadcrumb-separator">/</span> ', $breadcrumb) . '</div>';
  }
}

Comment	File	Size	Author
#2	quickfix_1429176-1.patch	635 bytes	Chi
#1	quickfix_1429206-0.patch	647 bytes	Chi

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Chi CreditAttribution: Chi commented 5 February 2012 at 15:42

Status:

Active

» Needs review

File	Size
quickfix_1429206-0.patch	647 bytes

File	Size
quickfix_1429176-1.patch	635 bytes

Comment #3

gtsopour CreditAttribution: gtsopour commented 5 February 2012 at 15:50

Status:

Needs review

» Active

Hello Chi and thank you for reporting this,

Could you check please the following function inside template.php of Drupal 7 Garland theme? I think that the following function returns a themed breadcrumb trail with the same way as corporateclean_breadcrumb().

/**
 * Return a themed breadcrumb trail.
 *
 * @param $breadcrumb
 *   An array containing the breadcrumb links.
 * @return a string containing the breadcrumb output.
 */
function garland_breadcrumb($variables) {
  $breadcrumb = $variables['breadcrumb'];

  if (!empty($breadcrumb)) {
    // Provide a navigational heading to give context for breadcrumb links to
    // screen-reader users. Make the heading invisible with .element-invisible.
    $output = '<h2 class="element-invisible">' . t('You are here') . '</h2>';

    $output .= '<div class="breadcrumb">' . implode(' › ', $breadcrumb) . '</div>';
    return $output;
  }
}

Thank you for your time.
/George

Comment #4

gtsopour CreditAttribution: gtsopour commented 5 February 2012 at 15:53

Assigned:	Chi	» gtsopour
Issue tags:		+corporate, +Corporate Theme, +Corporate Clean Theme

Comment #5

Chi CreditAttribution: Chi commented 5 February 2012 at 16:12

Assigned:	Chi	» gtsopour
Status:	Needs review	» Active
Issue tags:		+corporate, +Corporate Theme, +Corporate Clean Theme

Yup, I have already filed bug report about garland_breadcrumb(). It seems like many contributed themes just copied garland implementation of this. I am going to report the issues for others.