Similar to #1079960: Advanced options that require return values do not work, the timeoutFn function is supposed to return a result. This doesn't work currently because of the use of eval. The fix is simply doing the same as for pagerAnchorBuilder; providing a returnVal variable which can be set by user code.
It defaults to the global value so hopefully it returns something sane even if the user's code has a bug.

Possibly there are some other functions that need this change too, but the JQuery Cycle Plugin documentation page isn't very clear about which functions are supposed to return a value and which are called purely for their side-effects.

timeoutFn.patch800 bytesTimusan
Members fund testing for the Drupal project. Drupal Association Learn more


MustangGB’s picture

Version: 7.x-3.0 » 7.x-3.x-dev
Status: Patch (to be ported) » Needs review

Fix it in dev first, also if you have a patch it's CNR

czigor’s picture

Works for me, thanks!

NickWilde’s picture

Issue summary: View changes
Status: Needs review » Fixed

patched, thanks!

  • NickWilde committed b975398 on 7.x-3.x authored by Timusan
    Issue #1424090 by Timusan: timeoutFn advanced option does not work -...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.