Anonymous user issue: Undefined property: stdClass::$timezone in rate_expiration_node_insert [#1421016]

I created a content type. When a registered user enters content, everything is fine. When an anonymous user enters information, the content posts but I get the following:

Notice: Undefined property: stdClass::$timezone in rate_expiration_node_insert() (line 184 of /home/MySite/public_html/MySite.com/sites/all/modules/rate/expiration/rate_expiration.module).

184 $timezone = is_null($user->timezone) ? variable_get('date_default_timezone', 0) : $user->timezone;
185 if (!is_numeric($timezone)) {
186 // Convert textual timezone to numeric offset.
187 $timezone = new DateTimeZone($timezone);
188 $timezone = $timezone->getOffset(new DateTime('now', $timezone));

Note: Content type/Display settings set to "Don't display post information"

Does the code above account for an anonymous user(s)?

Rate 7.x-1.3
Drupal 7.10 - all modules up to date

Comment	File	Size	Author
#9	rate-is_null_fix-1421016-9.patch	1.65 KB	nicrodgers
#9
#1	rate_expiration-timezone_notice-1421016-1.patch	680 bytes	InternetDevels
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

InternetDevels CreditAttribution: InternetDevels commented 4 June 2012 at 14:31

Status:

Active

» Patch (to be ported)

File	Size
rate_expiration-timezone_notice-1421016-1.patch	680 bytes

There is no timezone for anonymous user so to prevent notice isset() needed

Comment #2

xbrianx CreditAttribution: xbrianx commented 1 August 2013 at 15:53

I am getting the same issue.

Comment #3

xbrianx CreditAttribution: xbrianx commented 1 August 2013 at 16:24

I tried the patch but am still getting the notice on commerce checkouts

Comment #4

fabul CreditAttribution: fabul commented 6 November 2013 at 15:54

Bonjour,
Dans le fichier sites/all/modules/rate/expiration/rate_expiration.module
remplacer
$timezone = is_null($user->timezone) ? variable_get('date_default_timezone', 0) : $user->timezone;
Par
$timezone = (!isset($user->timezone)||is_null($user->timezone)) ? variable_get('date_default_timezone', 0) : $user->timezone;
Et le module fonctionnera mieux.
J'espère que cette solution permettra aux auteurs de corriger le module.

Comment #5

xbrianx CreditAttribution: xbrianx commented 6 November 2013 at 17:19

That replacement worked Kalamityjane

Comment #6

leymannx

he/him

German

Berlin

CreditAttribution: leymannx commented 11 March 2014 at 11:51

Issue summary:

View changes

#4 worked! Even in French ;) Thank you.

Comment #7

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 30 April 2014 at 20:16

Status:

Patch (to be ported)

» Needs review

@InternetDevels: Please set the issue status to "Needs review" when you upload a patch, that way people know that there's a patch that needs review. Only change the status to "Patch (to be ported)" when there's an existing patch for one branch that needs to be ported to another branch, e.g. if someone fixes a bug for 7.x-1.x and the patch needs to be backported to 6.x-1.x.

Comment #8

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 30 April 2014 at 20:16

Version:

7.x-1.3

» 7.x-1.x-dev

Lets see if this can be tested against the current 7.x-1.x codebase.

Comment #9

nicrodgers

English

Monmouthshire, UK

CreditAttribution: nicrodgers commented 3 June 2014 at 10:17

File	Size
rate-is_null_fix-1421016-9.patch	1.65 KB

I suggest changing is_null() to empty() as this handles the case where we have an empty string. (I had this whilst reacting on a commerce checkout rule).

Here's a patch that converts the three is_null($user->timezone) ifs to empty(), which seems to work for me.

Comment #10

brad.bulger CreditAttribution: brad.bulger commented 29 December 2014 at 22:56

applied the patch in 9 to 1.7 and it's working fine for me.

Comment #11

erwangel CreditAttribution: erwangel commented 9 January 2015 at 10:57

Patch #9 applied to 1.7 working for me also. By the occasion, I think the test
$timezone = empty($user->timezone) ? variable_get('date_default_timezone', 0) : $user->timezone;
near line 203, inside the foreach ($widgets as $widget) { is unnecessary because it is already done at the beginning of the function just some lines before.