Media module (and core too) makes use of a.button as links that should look like buttons. These currently appear just as normal links in Rubik.

CommentFileSizeAuthor
#10 Screen Shot 2012-07-03 at 10.53.21 PM.png37.82 KBjeffschuler
#8 Screen Shot 2012-07-02 at 3.45.39 PM.png34.93 KBpschuelke
#2 1418412-rubik-a-button-styling.patch3.53 KBdave reid
#1 1418412-rubik-a-button-styling.patch2.87 KBdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 1418412-rubik-a-button-styling.patch2.87 KB
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 1418412-rubik-a-button-styling.patch3.53 KB

This also extends the button-yes and button-no classes as well.

zany’s picture

zany commented

The Media module additionally uses

<a class="button launcher" href="#">Select media</a>
<a class="button remove" href="#">Remove media</a>
<a class="button fake-ok">Submit</a>
<a class="button fake-cancel">Cancel</a>

I addressed those with an override to map to a plus button, minus button, button-yes, button-no, respectively.

Is it ok to request this here or should the Media module be asked to conform to some best practice?

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

If it's just classes that we need to add to the Media buttons, we can do that in Media. I've already added support for things like button-yes and button-no that are supported by Rubik.

niccolox’s picture

niccolox commented

what version of Rubik is that patch for ?

I am trying to apply it to latest release 7.4 beta 8 and getting problems i.e. not applying cleanly

Anonymous’s picture

Anonymous (not verified) commented

I'm on 7.x-4.0-beta8 also, but I've been having problems with "git apply" not working on a lot of patches recently - as in no output even with --verbose.

That said, it applied almost cleanly for me with "patch -p1 < 1418412-rubik-a-button-styling_0.patch" (fuzz 1). However, it seems to work fine.

codi’s picture

codi commented
Status: Needs review » Reviewed & tested by the community

Reviewed the patch and it applies fine against the dev branch. I'm creating a new issue for a few more media issues i'm having with rubik, but this patch as it is can be committed.

pschuelke’s picture

pschuelke commented
StatusFileSize
new Screen Shot 2012-07-02 at 3.45.39 PM.png34.93 KB

After I ran the patch I'm still getting styling issues. The filed-set is not around the thumbnail or buttons.

pschuelke’s picture

pschuelke commented

I combined #2 with issue 1623510

http://drupal.org/node/1623510#comment-6188482

jeffschuler’s picture

jeffschuler
Location Boulder, Colorado
commented
StatusFileSize
new Screen Shot 2012-07-03 at 10.53.21 PM.png37.82 KB

Patch in #2 is good, except the Submit & Cancel buttons could use some space (see screenshot.)

Could we do: .form-actions { margin-top: 20px; }?

pschuelke’s picture

pschuelke commented

jeff

check out

http://drupal.org/node/1623510#comment-6191568

coffeymachine’s picture

coffeymachine commented
Status: Reviewed & tested by the community » Closed (duplicate)

I am going to close this issue as it has been combined with #1623510: Media module weirdness
Let's move any further discussion about this over to that thread.