Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The "WARNING: Disabling SQL rewriting means that node access security is disabled..." warning shows up at the top of the query settings dialog. It draws attention to itself even when the user had no intention of disabling SQL rewriting. I think it would be reasonable to display the warning only after the user checks the corresponding checkbox. In fact, the movement on the screen should attract even more attention.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 1416018-1.sql-rewrite-warning.patch | 1.89 KB | ksenzee |
Comments
Comment #1
ksenzeeI added a generic Drupal.behaviors.viewsUiEditView to views-admin.js because I don't think such a small snippet warrants its own behavior, but there didn't seem to be a generic one to put it in. Another approach would be to make the warning a separate form element and use dependency for it, and if that's preferred I can reroll the patch.
Comment #2
dawehnerNow that query settings has more then this option this definitive makes sense.
In fact this really absorbs attention. Thanks! Committed to 7.x-3.x
In general maybe the warning text could be improved as well, because it's currently quite technical.