Notice: Undefined variable: email_address in webform_mailchimp_webform_submission_insert() [#1415798]

So I've actually stumbled upon a couple small notices while working on things. The first two occur when you submit a form that has an email field and the MailChimp field is tied to that email field, but you don't actually click the "Subscribe" checkbox for MailChimp. Basically in my use, I have a contact form where you can opt to sign up for the newsletter and if you do, it should use the email address field you provide in the form.

All I think we need is a check on the MailChimp field that will only run the code referenced if that checkbox is checked.

Notice: Undefined variable: email_address in webform_mailchimp_webform_submission_insert() (line 151 of /sites/all/modules/custom/webform_mailchimp/webform_mailchimp.module).
Notice: Undefined variable: email_address in webform_mailchimp_webform_submission_insert() (line 125 of /sites/all/modules/custom/webform_mailchimp/webform_mailchimp.module).

In light of the above notices, I opted to go with the option of having MailChimp field create the email field for me. I got the second notice below:

Notice: Undefined variable: size in _webform_render_mailchimp() (line 210 of /sites/all/modules/custom/webform_mailchimp/webform_mailchimp.inc).

Easy enough to fix, just commented out line 211 defining the size of the text field.

Comment	File	Size	Author
#3	webform_mailchimp-email_address_variable_fallback-1415798.patch	503 bytes	jnettik

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

blackdog CreditAttribution: blackdog commented 31 January 2012 at 12:44

Status:

Active

» Postponed (maintainer needs more info)

I don't think this is an issue anymore. Can you confirm?

Comment #2

jnettik

English

Denver, CO

CreditAttribution: jnettik commented 31 January 2012 at 17:10

Status:

Postponed (maintainer needs more info)

» Active

I'm still getting the error:

Notice: Undefined variable: email_address in webform_mailchimp_webform_submission_insert() (line 126 of /home/afcishow/public_html/sites/all/modules/contrib/webform_mailchimp/webform_mailchimp.module).

I think the problem is with the the if statement below starting on line 38.

  // Need to know if we should look for our own email field or another.
  if ($field['extra']['use_existing_email_field'] != 'mailchimp_field') {
    // If using existing field, check if the checkbox was checked
    if ($submission->data[$key]['value'][0] == 1) {
      // Loop through components again to find our email field
      foreach($node->webform['components'] AS $key2 => $field2) {
        if ($field2['form_key'] == $field['extra']['use_existing_email_field']) {
          // Get the form value
          $email_address = $submission->data[$key2]['value'][0];
        }
      }
    }
  }
  // We have our own email field
  else {
    $email_address = $submission->data[$key]['value'][0];
  }

It looks like you're checking that I'm not using a generated email field, which I'm not. Then checks if the checkbox was checked, which it wasn't. So the $email_address never gets created. I think there needs to be some way for users to submit an email address field without subscribing to the newsletter.