I am working on writing a custom conditional action, and was looking at the different triggers. The one I want to use, 'uc_recurring_renewal_failed' is fired in uc_recurring_renew(). In the case of of Paypal WPS, the IPN page callback only calls uc_recurring_renew() for txn_type = 'subscr_payment' or txn_type = 'recurring_payment'.

I think that adding these two lines from uc_recurring_renew() to the subscr_failed and recurring_payment_failed conditions would fix this.

module_invoke_all('recurring_renewal_failed', $order, $fee);
ca_pull_trigger('uc_recurring_renewal_failed', $order, $fee);

Does that sound right, or am I missing something?

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jojonaloha’s picture

Version: 6.x-2.0-beta1 » 6.x-2.x-dev
Status: Active » Needs review
FileSize
1.14 KB

Here is a patch for the proposed change.