Fix upgrade check for D8 and php 5.3

Is this check intended to be included as a hook_update_N implementation in an install profile, or would it be better as a fatal error in update.php?

We have a nice requirement check screen the first page of install.php (if there are environment errors), it'd be good to have the same on update.php. I thought we did at one point but perhaps not.

Actually, install.php exits immediately if PHP requirement isn't met. Should it be implemented in update.php in the same manner?

Basically a straight lift from install.php.

Meh

This seems like the right approach to me.

vortex:drupal-head dries$ grep -r "Your PHP" *
core/install.php:  print 'Your PHP installation is too old. Drupal requires at least PHP 5.3.2. See the <a href="http://drupal.org/requirements">system requirements</a> page for more information.';
core/modules/system/system.install:    $requirements['php']['description'] = $t('Your PHP installation is too old. Drupal requires at least PHP %version.', array('%version' => DRUPAL_MINIMUM_PHP));

It looks like system.install does a check as part of system_requirements().

Do we not run hook_requirements as part of the site installation or site upgrade process?

Hook requirements is definitely run as part of the site install and update procedure, so I guess this bug is moot.

A quick test:

██ cam8001 @ /var/www/drupal-8-trunk
██ 22:47:40 $ git diff core/modules/system/system.install 
diff --git a/core/modules/system/system.install b/core/modules/system/system.ins
index 7a275e8..3422056 100644
--- a/core/modules/system/system.install
+++ b/core/modules/system/system.install
@@ -54,7 +54,7 @@ function system_requirements($phase) {
   );
 
   // Test PHP version and show link to phpinfo() if it's available
-  $phpversion = phpversion();
+  $phpversion = 5.1;
   if (function_exists('phpinfo')) {
     $requirements['php'] = array(
       'title' => $t('PHP'),


██ cam8001 @ /var/www/drupal-8-trunk
██ 22:47:53 $ drush updb
Your PHP installation is too old. Drupal requires at least PHP 5.3.2.[warning]
(Currently using PHP 5.1)
No database updates required                                         [success]
Finished performing updates.                                         [ok]

Re: #10, I thought the issue was not that a message was not shown, but that errors appeared before the check?

Maybe someone should actually test it on 5.2. :)

Okay, I just tested on 5.2, and yes, this issue is necessary. Here's why:

Quite right, confirmed here too under PHP 5.2.17.

Parse error: syntax error, unexpected T_CONST in /Users/cam8001/Sites/drupal-8-trunk/core/update.php on line 31

However, the patch doesn't appear to work. I assume the whole file is parsed before any code is run, which means that PHP < 5.3 will raise a fatal error as soon as it finds any unsupported syntax.

Mmm, but the patch does not actually resolve the issue. It still contains a const keyword, so it fails as the file is parsed.

We need to use define here as well:

const MAINTENANCE_MODE = 'update';

Attached uses the same strategy as in install.php. This resolves the issue for me locally under 5.2.

Patch works well for me here too, tested with PHP 5.2.17.

This looks good to me. The system_requirements() check works if we were to raise the minimum requirement to 5.3.4 or similar, we could leave this workaround as is at 5.3.2 in that case.

If we wanted to we could make the update.php/install.php check for 5.3.0 so there's a pretty error message between the syntax error and things working, but I don't think anyone runs > 5.3.0 and < 5.3.2 anyway so that's probably moot at the moment.

Tested patch from #15. All OK.

Yeah, I think it's good to give folks with PHP 5.3.0 the workaround message as well.

Thanks! Committed/pushed to 8.x.

I ran into this issue when I went to: mydomain.com/drupal/
The error message when you go directly to your new Drupal install is (from the latest dev):
Parse error: syntax error, unexpected T_STRING, expecting T_CONSTANT_ENCAPSED_STRING or '(' in /home/martindavisiii/d8.md3productions.com/drupal/core/includes/bootstrap.inc on line 3

However, the nicely formatted error message below does show up if you go to: mydomain.com/drupal/core/install.php
Your PHP installation is too old. Drupal requires at least PHP 5.3.3. See the system requirements page for more information.

For more information and discussion on this issue, please see:
#1463564: Drupal 8 does not work with PHP 5.3.2 (the version shipped with Ubuntu 10.04 LTS)