Reorder mappings [#1410296]

I wanted to reorder my mappings to get the columns in the template CSV file in the right order. But to do this I had to remove all mappings and add them again. That's not fun... so I wrote a patch that's add a weight column and tabledrag for some easy reordering.

Comment	File	Size	Author
#2	1410296-reorder-mappings.patch	4.82 KB	vinmassaro
#2
#1	feed_ui_reorder_mappings-1410296-1.patch	3.46 KB	logaritmisk
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

logaritmisk CreditAttribution: logaritmisk commented 19 January 2012 at 13:00

Status:

Active

» Needs review

File	Size
feed_ui_reorder_mappings-1410296-1.patch	3.46 KB

Comment #2

vinmassaro CreditAttribution: vinmassaro commented 3 July 2012 at 17:44

File	Size
1410296-reorder-mappings.patch	4.82 KB

This is a very helpful feature for an importer I am building with over 30+ mappings that will eventually need to be reordered. Your patch worked for me except when there were no mappings defined and I clicked 'Save' on the feed importer. It returned an error because $mappings was empty, so I added a condition to check if it's empty. I've rolled a new patch against 7.x-2.x that is git aware and combines these changes. Thanks!

Comment #3

anon

Swedish

Gothenburg

CreditAttribution: anon commented 9 August 2012 at 09:48

Status:

Needs review

» Reviewed & tested by the community

Awesome, the patch in #2 works perfect, don't know what more to say. Grate job both of you!

Comment #4

twistor CreditAttribution: twistor commented 10 August 2012 at 06:24

Status:

Reviewed & tested by the community

» Needs work

Very nice!

An error is thrown when you remove a mapping because the arrays are different sizes. Also, this should have a test that goes through the basic functionality to avoid regressions.

I like it.