I couldn't get this to work with version 3 of video-js, had to revert to 2.0.2 (for which there is no git branch or download option, I had to grab the files from a patch revision on github)

Comments

lightsurge’s picture

This is probably to be considered a duplicate of #1402846: Compatibility with VideoJS v. 3 (which I didn't spot because of the version)

I don't know if you want to leave this open for a patch backport.

Jorrit’s picture

Status: Active » Postponed (maintainer needs more info)

Please test tomorrows 6.x-1.x dev release to check if it works with VideoJS version 3.

lightsurge’s picture

This seemed to work fine on Chrome. Only one problem, I'm using it with Video module, and the video thumbnail didn't display, just got a black background, but that might be an issue for me to put in video.module's queue.

IE8 was another story however, it hanged the javascript interpreter. As usual the error message given was fairly useless, apart from pointing to this point in video-js code:

this.box.style.width = this.width() + "px";

in the "VideoJS Box - Holds all elements" section.

I suppose it must be something to do with the Flash fallback not working correctly, since that's where IE8 differs in terms of not being HTML5 happy.

On that subject, any plans to add in the Flash fallback player to 6.x? Maybe that would just fix it.

bradjones1’s picture

@Jorrit - mind looking at the D7 companion #1402846: Compatibility with VideoJS v. 3 and giving me your feedback?

Jorrit’s picture

I did not realize that the new VideoJS version brings its own Flash fall back player. I think it is best to create new 2.0 versions for both Drupal 6 and 7 that only support the new VideoJS version, because then a lot of code can be removed.

Jorrit’s picture

Status: Postponed (maintainer needs more info) » Fixed

I have created a new version for Drupal 6 that has VideoJS v3 support.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.