video and audio types are inverted what breaks the player.
Moreover $raw_files often already contains the type key.

Members fund testing for the Drupal project. Drupal Association Learn more


drzraf’s picture

deviantintegral’s picture

Status: Active » Needs work

Functionally this looks fine, but there are some code style / spacing issues to be cleaned up.

drzraf’s picture

Status: Needs work » Reviewed & tested by the community

it is not an issue, I encapsulated a block in a if statement thus I generated the commit with diff -w in order to make the change readable.
1 files changed, 13 insertions(+), 11 deletions(-)
1 files changed, 4 insertions(+), 2 deletions(-)

stevetweeddale’s picture

Assigned: drzraf » Unassigned
Status: Reviewed & tested by the community » Needs review
1.1 KB

Attached a cleaned up version of #1.

stevetweeddale’s picture

Hold the phone, looks like this has already been fixed in #1192826: Undefined variable: player_type in jplayer_sort_files() in the within the patch in #19. Gah.

deviantintegral’s picture

Status: Needs review » Fixed

Since that patch is still at needs review, I committed this in dafadd3.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.