Hi

trying to change the image of marker but getting broker (like image not found) on the map
please view the attachment.
all the path to img styles and file located in correct directory.

please advice.

Files: 
CommentFileSizeAuthor
#19 openlayers-1404912-7.x-2.0-beta7-do-not-test.patch1.87 KBtobiasb
#17 openlayers-1404912.patch2.15 KBtobiasb
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch openlayers-1404912.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

j0rd’s picture

Version:7.x-3.x-dev» 7.x-2.x-dev

I have the same problem.

@martin.riggs by any chance is your site a multi-lingual site?

It works fine for me when the language is set to the default language english.

Path example:
domain.tld/sites/all/modules/contrib/openlayers/theme/default_dark/img/marker-red.png

But when I switch the language to French, which uses a prefix folder, I get this path for the image which is a 404
domain.tld/fr/sites/all/modules/contrib/openlayers/theme/default_dark/img/marker-red.png

The /fr/ appears to be the problem. Most likely the Javscript used in this module isn't setting up the paths right. This might also be a problem for you if your Drupal is installed in a sub-folder I'm guessing

j0rd’s picture

Title:Broken image of marker» Broken image of marker in map when Drupal translation paths are used.

Adding a better title.

j0rd’s picture

Status:Active» Needs review
StatusFileSize
new1.57 KB
PASSED: [[SimpleTest]]: [MySQL] 236 pass(es).
[ View ]

I've attached a patch, which adds base_url() to the externalGraphic paths.

@martin.riggs Please apply it and see if it works for you.

martin.riggs’s picture

Thank, but please don't be mad on me, i never applied patches
could you guide me in few lines how to do it ?
i actually could follow the diffs by if there some better way i would like to know..
and thanks again...

j0rd’s picture

If you've downloaded the module through git, you go into the module folder and `git apply -v PATCH.patch`

If you've simply downloaded the source, you do `cd sites/all/modules/openlayers; patch -p1 < PATCH.patch`

the `patch` command is with linux. If you're using mac or windows, you''ll have to do some reading for those OS's

Here's more information http://drupal.org/node/707484. Usually a quick google will solve these problems for you.

nod_’s picture

Status:Needs review» Needs work

I'd go with file_create_url() instead of base_path(), it's the same issue we had with URL using ${dynamic}.

nod_’s picture

Actually, try this patch instead #1364778: openlayers_style_path() must not use url() to create file paths. and tell me if it fixes the problem.

RuiMendes’s picture

I worked thanks

nod_’s picture

Status:Needs work» Fixed

I'll commit the patch later, unless there is still an issue here.

martin.riggs’s picture

ok, thanks, i will wait for your update, meanwhile i working with default style.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

RuiMendes’s picture

Sorry but this only works with clean urls.

If you can't use clean urls this patch won't work. It tries to get the image from:
localhost/?q=sites/all/modules/openlayers/themes/default_dark/img/marker-blue.png

the ?q= breaks the url.

Thanks

RuiMendes’s picture

Status:Closed (fixed)» Active

upps forgot to reopen

Sorry but this only works with clean urls.

If you can't use clean urls this patch won't work. It tries to get the image from:
localhost/?q=sites/all/modules/openlayers/themes/default_dark/img/marker-blue.png

the ?q= breaks the url.

Thanks

nod_’s picture

Does the patch in #7 fixes this ? I'm sorry haven't got around committing it yet.

RuiMendes’s picture

Status:Active» Closed (fixed)

Sorry. You are right.

I was using the old patch, the one that doesn't use the file_create_url()

Thanks.

jrogen’s picture

Status:Closed (fixed)» Patch (to be ported)

This is still in the current versions over a year later. Can this be rolled in?

tobiasb’s picture

Title:Broken image of marker in map when Drupal translation paths are used.» Broken file paths in map when Drupal translation paths are used.
Component:OL Styles» Code
Issue summary:View changes
Status:Patch (to be ported)» Needs review
StatusFileSize
new2.15 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch openlayers-1404912.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

This happens also for file urls in layers etc.

tobiasb’s picture

StatusFileSize
new1.87 KB

This patch is for the current stable release.

tobiasb’s picture

StatusFileSize
new1.87 KB

* Added "do-not-test" to filename.

Pol’s picture

Status:Needs review» Fixed

Excellent, committed and pushed!

Thank you very much !

Status:Fixed» Needs work

The last submitted patch, 17: openlayers-1404912.patch, failed testing.

The last submitted patch, 18: openlayers-1404912-7.x-2.0-beta7.patch, failed testing.

Pol’s picture

Status:Needs work» Fixed

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.