Compatibility with VideoJS v. 3

Here's my first shot at an implementation for VideoJS 3. There's a few API changes, plus a simplification of the skinning system. I have shed the Drupal config options for player theming for now, though it'd be easy enough to put back in. This is working on my local dev with VideoJS 3.0.7.

One more (in addition to, not in replace of) patch to get rid of unnecessary flash fallback, since version 3 comes with its own and auto-detects its media.

I'd think because this is related to an external library API change this would qualify for a 2.x (or 3.x??) version of the module, to make it clear which version it plays nice with?

I downloaded the latest 7.x-1.x-dev.tar.gz from the project page and tried to apply the patch in #1 but it failed.

-bash-3.2$ git apply videojs-v3-1402846-1.patch
videojs-v3-1402846-1.patch:68: space before tab in indent.
        $vars['flash'] = NULL;
error: patch failed: videojs.info:5
error: videojs.info: patch does not apply

Any idea what I'm doing wrong? I'd love to get this patch commited in to the project.

I will do such a happy dance when this is implemented. Wish I had the know-how to outfit that patch for D6.

@Smenzo - it applies cleanly for me if you do patch -p1 < videojs-v3-1402846-1.patch - try that?

Not sure why git is choking on the diff.

bradjones1: please only post complete patches, not incremental patches. Your patch also adds information to the info file that should not be there.

The patch looks OK. As I said in the 6.x issue, I think it is best to start a new version of the module. People that do not want to update to VideoJS 3 can keep using v1 of the module.

@Jorrit - would you prefer a tarball? I've done a bit more work on this and agree it's probably easier to start a new branch.

No, I meant that it is better to provide complete patches as opposed to incremental patches. If you have an updated patch, feel free to post it here.

I'm not sure where to place my problem, but no matter what version of VideoJS I use, the flash fallback in Internet Explorer returns the following error (while loading the player to the wrong dimensions and no video). Flowplayer works correctly in other instances, just not when called by videojs:

Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; InfoPath.2; .NET4.0C; .NET CLR 2.0.50727; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729)
Timestamp: Tue, 31 Jan 2012 01:00:06 UTC

Message: 'VideoJS' is undefined
Line: 12
Char: 3
Code: 0
URI: http://www.kingprods.com/gavin/sites/all/modules/videojs/theme/videojs.j...

It's the following page, which now works in almost all browsers except IE8:

http://www.kingprods.com/gavin/node/62

@SuperRookie, your problem sounds more like #1235452: VideoJS.setupAllWhenReady need to be called after video.js library - there is a patch over there.

Brad,

I applied the patch, and the error went away, but flowplayer is still not loading the video in ie8. All the HTML5 instances work just fine, but flowplayer (which works correctly when called directly) does not work when called by videojs.

Check this link if you can in an older IE and compare to other browsers (if you can):

http://www.kingprods.com/gavin/node/64

SR

@Jorrit - here's a complete patch which supercedes everything from above.

@SuperRookie - I was running into the same problem with IE < 9, and I tracked it down to the detailed codecs that were being provided by this module - turns out VideoJS now expects a string without the ; codecs= part.

Yep, I noticed that as well. Video-JS does an exact match on the codec field to find the video/mp4 version to use for the Flash player. Also see https://github.com/zencoder/video-js/issues/124

@SuperRookie: Flowplayer will not be called anymore after this patch is applied. With Video.js 3, there is no need for a separate Flash fallback, because it has its own. I have fixed some bugs in the current version of the Video module, which is just for Video.js 2.0. You may want to check out the 7.x-1.x-dev release tomorrow to see if it works for you.

@bradjones1: As you have noticed, I have addressed almost all current bugs in the Video.js module. Could you try to create the patch to the current 1.x branch? If you do not have time for this, I will try to do it next week.

@Jorrit - try this, re-rolled against the latest 7.x-1.x.

The patch has been committed and released as 7.x-2.x.