Check out a git repository viewer page such as
http://drupalcode.org/project/api.git
(you may need to refresh your browser cache). The contrast on that page is extremely low, making it hard for me to read and likely impossible for people with sight difficulties.

The CSS in
http://drupalcode.org/gitweb.css
probably needs to be adjusted (the color: #545454 directives seem to be the problem).

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

apaderno’s picture

I don't have any problems with that page, on Safari 5.1.2 running on Mac OS X 10.7.2. The contrast is not too low, on my computer; I would rather say it is normal.

drumm’s picture

http://snook.ca/technical/colour_contrast/colour.html is what I use to check against accessibility standards.

Using colors from http://drupal.org/node/1051644 are preferred, and updating that page if Drupal.org is doing something different.

Everett Zufelt’s picture

The WCAG 2.0 level AA requirement is that contrast be at a 4.5:1 ratio.

I use the Juicy Studio toolbar at https://addons.mozilla.org/en-US/firefox/addon/juicy-studio-accessibilit...

jhodgdon’s picture

FileSize
87.42 KB

Here is what I am seeing. kiamlaluno: if you are not seeing that, try refreshing your browser cache. You may not have the current CSS.

jhodgdon’s picture

I used the Colour Contrast Check site Drumm provided.

In the table that lists the commits, the foreground color is apparently 4183C4, and the background is a gradient from F9F9F9 to EFEFEF. This is not compliant according to that site.

In the line that says "shortlog" (blue on blue), the background is EAF2F5 and the foreground is 4183C4. This is not compliant.

In the description block, the background is F0F0F0 and the foreground is 222222. This is compliant, but I think it could have a better contrast.

I also think the whole site used to have better color contrast a few weeks ago. It would be good to change it back to how it was -- much more readable.

apaderno’s picture

I had to refresh the browser's cache, or I would have seen the pages with the old theme. I refreshed the browser's cache, and then I looked at the page.

jhodgdon’s picture

I'm not sure kiamlaluno -- are you saying you don't see the same colors as I am seeing (see #4/5), or that you don't think they're as bad as I think they are (I believe they violate international accessibility guidelines, plus they're no where near as high-contrast as drupal.org)?

tim.plunkett’s picture

FileSize
870 bytes

Copying over my suggestion from #1395988-2: Changes to the new CSS on drupalcode.org and removing the purple background for strings.

Obviously this is more relevant for the other issue, and doesn't address the contrast concerns.

Dave Reid’s picture

Issue filed against the actual gitweb theme here: https://github.com/kogakure/gitweb-theme/issues/6

jhodgdon’s picture

Dave Reid: #8 says it "doesn't address the contrast concerns", so I'm not sure you want to propose it as a solution to the contrast problems on github?

Dave Reid’s picture

Changing the font itself drastically improved some of the contrast for me as the font was more black.

Everett Zufelt’s picture

FileSize
6.72 KB

The attached document is the Juicy Studio colour contrast report for the page http://drupalcode.org/project/api.git

jhodgdon’s picture

Thanks Everett. That's pretty conclusively a failure to meet standards.

apaderno’s picture

@jhodgdon How I see it, there is more contrast between the background and the text; when you say that it is hard for you to read the page, I don't have any problem in reading it.
I am using Safari 5.1.2 running on Mac OS X 10.7.2. I also tried with Google Chrome, and I cannot say it's hard for me to read the page.

apaderno’s picture

FileSize
43.95 KB

This is how I see the same page with Google Chrome.

I can see there is a slightly difference in contrast between Safari and Google Chrome; it's not a difference that doesn't allow me to read the text, but still it seems there is a difference.

I took the screenshots from the same computer, using the same utility. There should not any difference between the screenshots that are caused from how the files are saved/compressed.

greggles’s picture

"hard for me to read the page" is a really subjective measure that depends on tons of factors like the monitor you're using, the amount of light in the room, the brightness/contrast settings on the monitor, etc.

Luckily we have software to tell us if contrast is good or not, such as what Everett posted or drumm's website.

The theme needs some tweaks - let's post them as patches to the github project as dave has done and perhaps get those deployed locally in the meantime.

skottler’s picture

Priority: Normal » Major
Status: Active » Needs review

I am working on this locally. I need to talk to @sdboyer about the Git dev environment to collect feedback on the changes to the CSS. In the meantime, would it be best to revert it until there is community consensus on accessibility and readability?

longwave’s picture

+1 to reverting this while a better fix is implemented, I find these pages extremely difficult to read at present and it looks like I'm not the only one.

killes@www.drop.org’s picture

Status: Needs review » Fixed

I tentatively mark this fixed comparing what I see to https://drupal.org/files/lowcontrast.png

longwave’s picture

Status: Fixed » Active

http://drupalcode.org/project/api.git and https://drupal.org/files/lowcontrast.png still look the same to me in Firefox on Linux.

jhodgdon’s picture

Agreed with #20. The git repo is still extremely low contrast, and for me (Firefix/Ubuntu) at least, still looks exactly like the screen shot in #19. What are you seeing?

pjcdawkins’s picture

Agreed with #20 and #21, using Google Chrome on Ubuntu. Screenshot attached.

tim.plunkett’s picture

Mac Chrome looks like this, which is probably why the issue was closed (it has great contrast)
Screen Shot 2013-10-14 at 8.37.02 AM.png

killes@www.drop.org’s picture

no, I use FF on Linux as well and for me the contrast is not great but better than in the screenshot. Maybe because I override fonts locally.

In a few weeks we'll have a different viewer and can tune that...

drumm’s picture

Status: Active » Closed (won't fix)

Watch #2099271: Deploy cgit on new git servers for the new Git browser. Gitweb is unmaintained and we don't want to deploy it on our new Git servers at all. I expect we'll stick with the default look for the initial deployment, but can do something else if we have some direction.

Component: drupalcode.org » Git