media.css includes the following css, which is too generic and affects elements that have nothing to do with media, causing an inconsistant browsing experience in some cases.

a.button {
  display: inline-block;
  margin: 10px 5px 0 0;
}

So on pages where media.css is loaded, any link with the .button class gets the above styling. This css should be more targeted towards the elements that is supposed to effect, which presumably are some elements provided by the media module?

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mrfelton’s picture

Status: Active » Needs review
FileSize
539 bytes

I think this resolves appropriately.

Dave Reid’s picture

Assigned: Unassigned » Dave Reid

Assigning for review.

dddave’s picture

#1502060: Clean up media.css claims to heal this wound here too.

mrfelton’s picture

Maybe, but it's against 2.x, doesn't apply against 1.x, and I don't have time to try and make make it do that. Thi patch on the other hand is much smaller, simpler and easier to re-roll to apply cleanly against 1.x. Updated version attached.

Dave Reid’s picture

Issue tags: +sprint, +Media Initiative
dgorton’s picture

Version: 7.x-1.x-dev » 7.x-2.x-dev
FileSize
450 bytes

At the TCDrupal Media sprint.

Per conversation, rolling vs 7.x-2.x first. Will back-port to 7.x-1.x if this passes muster.

Dave Reid’s picture

Version: 7.x-2.x-dev » 7.x-1.x-dev

Since I committed #1502060: Clean up media.css to 7.x-2.x, I think we only need to commit this to 7.x-1.x now since the 2.x patch removed all instances of a.button CSS.

Dave Reid’s picture

Status: Needs review » Fixed

Committed #6 to 7.x-1.x only since it applied cleanly. Thanks!
http://drupalcode.org/project/media.git/commit/84a4a65

Automatically closed -- issue fixed for 2 weeks with no activity.