User profile redirect link incorrectly formatted OSSO Relying Party [#1392860]

I get the following error when I click on the link in "Please visit the Single-Sign-On-Provider to change this field."

The requested page "/provider.example.com/?omniauth_redirect=http%3A//relying.example.com/user/1/edit" could not be found.

Comments

Comment #1

pyrello CreditAttribution: pyrello commented 3 January 2012 at 17:15

Project:

OpenID Single Sign On Relying Party

» OpenID Profile

Sorry, this actually appears to be a problem with the OpenID Profile module instead.

Comment #2

pyrello CreditAttribution: pyrello commented 3 January 2012 at 17:30

Title:

Redirect to provider link doesn't work (Page not found) OSSO Relying Party

» User profile redirect link incorrectly formatted OSSO Relying Party

Okay, this appears to be related to line 505 in this block of code:

array('!sso_name' => l(t('Single-Sign-On-Provider'),
  $provider['url'],
  array('query' => array('omniauth_redirect' => $path)))));

It seems that the provider['url'] needs to be prepended with "http://" or "https://" or the l() function interprets it as an internal link. I'm not sure what the best practice is for this sort of thing.

Comment #3

pyrello CreditAttribution: pyrello commented 4 January 2012 at 15:13

Issue tags:

+OpenID, +single sign-on, +osso

After some further investigation, I think I've determined that this works as intended. If you add the http:// or https:// in the actual field during configuration, it works just fine. I will suggest that the description on the form needs to be changed to indicate that the http(s):// is required and possibly add some error handling for that, since it doesn't seem to work without. I'll leave it up to the discretion of the maintainer (or the system bots) to close this thread.