Thanks to #1260716: Improve language onboarding user experience, we can now select a language as the first step of the installation process. However, st() still expects a profile to be selected before it will swap in phrases from other languages. Here's a fix.

If you test this, note that you'll probably have to apply the patch in #1392174: install_find_translation_files() breaks if $langcode is passed before you see a difference.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Garrett Albright’s picture

Status: Active » Needs review

Correct Status field.

David_Rothstein’s picture

You should upload a patch file without the "-D8" suffix in order to get the testbot to test it, but otherwise this looks good.

I didn't actually try out the patch, but seems like a no-brainer since I confirmed that in Drupal 8 st() no longer does anything with $install_state['parameters']['profile'] at all. So this should probably be RTBC once it passes tests.

Garrett Albright’s picture

Reupload with no -D8 suffix.

Gábor Hojtsy’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +D8MI

Looks great. Thanks David for the extra eyes!

catch’s picture

Status: Reviewed & tested by the community » Fixed

Looks good, not testable, committed/pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Gábor Hojtsy’s picture

Issue tags: +language-ui

Adding UI language translation tag.