Thanks to #1260716: Improve language onboarding user experience, we can now select a language as the first step of the installation process. However, st() still expects a profile to be selected before it will swap in phrases from other languages. Here's a fix.
If you test this, note that you'll probably have to apply the patch in #1392174: install_find_translation_files() breaks if $langcode is passed before you see a difference.
Comment | File | Size | Author |
---|---|---|---|
#3 | st_shouldnt_expect_profile_1392192.patch | 729 bytes | Garrett Albright |
st_shouldnt_expect_profile-D8.patch | 729 bytes | Garrett Albright | |
Comments
Comment #1
Garrett Albright CreditAttribution: Garrett Albright commentedCorrect Status field.
Comment #2
David_Rothstein CreditAttribution: David_Rothstein commentedYou should upload a patch file without the "-D8" suffix in order to get the testbot to test it, but otherwise this looks good.
I didn't actually try out the patch, but seems like a no-brainer since I confirmed that in Drupal 8 st() no longer does anything with $install_state['parameters']['profile'] at all. So this should probably be RTBC once it passes tests.
Comment #3
Garrett Albright CreditAttribution: Garrett Albright commentedReupload with no -D8 suffix.
Comment #4
Gábor HojtsyLooks great. Thanks David for the extra eyes!
Comment #5
catchLooks good, not testable, committed/pushed to 8.x. Thanks!
Comment #7
Gábor HojtsyAdding UI language translation tag.