Amazing module, thank for the D7 version!

I believe Taxonomy and Users "nodes" are not being checked, and they are just like any other node, can contain links. Can you expend the functionality to include them?

Comments

hass’s picture

Share a patch, please.

hass’s picture

Title:Checking Taxonomy & Users» Checking Taxonomy & Users fields
shaisamuel’s picture

I wish I new. Just doing my first steps.

edu2004eu’s picture

Subscribe.

neurojavi’s picture

Issue #1067120: Missing hook_taxonomy_term_view() or hook_entity_view() when viewing a term is solved for 7.x, the patch is included in 7.17.
Does this module need some change to work with terms now that the include the standard entity hooks or it just works now?

Thanks for this great module!

hass’s picture

Nope, this may need a lot of work.

Samvel’s picture

Assigned:Unassigned» Samvel
Status:Active» Needs review
StatusFileSize
new14.9 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch taxonomy-integration-1390872-8.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Hi guys,

In my work i need integration with taxonomy, bean and field_collection.

I created big patch for taxonomy part, please review it. I suggest exclude each functional part in different submodules(in future for existing parts too). Check how i did in my patch. I made ​​everything as well as in the main module.

To use not forget enable "linkchecker_taxonomy" module.

Status:Needs review» Needs work

The last submitted patch, taxonomy-integration-1390872-8.patch, failed testing.

Samvel’s picture

Status:Needs work» Needs review
StatusFileSize
new20.57 KB
PASSED: [[SimpleTest]]: [MySQL] 159 pass(es).
[ View ]

Again...

hass’s picture

Looks really good to me, but can you add some test, please?

Samvel’s picture

I can, but then later, because this work will be only in free time

hass’s picture

Well, are we not all working for free? At least me.

We should make sure that this will not break some days without getting noticed.

Samvel’s picture

Well, are we not all working for free? At least me.

Yes of cource, i meant that i needed this functional in my work.

We should make sure that this will not break some days without getting noticed.

Yes, of course. We can wait other reviews and in any case will be better also write tests. But i can't write it right now.

Samvel’s picture

Title:Checking Taxonomy & Users fields» Taxonomy, Beans, Users integration
StatusFileSize
new3.85 KB
PASSED: [[SimpleTest]]: [MySQL] 159 pass(es).
[ View ]

So, i split previous patch. Was appended few hooks to get independent of modules.

hass, please review this patch

After i will append patches for taxonomy and beans modules.

Samvel’s picture

StatusFileSize
new0 bytes
PASSED: [[SimpleTest]]: [MySQL] 159 pass(es).
[ View ]
Samvel’s picture

StatusFileSize
new17.96 KB
PASSED: [[SimpleTest]]: [MySQL] 159 pass(es).
[ View ]

Patch for taxonomy, again(previous patch WRONG).

Should be applied after integration-independent-modules-1390872-15.patch will be implemented!

Samvel’s picture

StatusFileSize
new17.82 KB
PASSED: [[SimpleTest]]: [MySQL] 159 pass(es).
[ View ]
new17.03 KB
PASSED: [[SimpleTest]]: [MySQL] 159 pass(es).
[ View ]

Appended patch for bean integration.
Small fixes in taxonomy integration.

Not forget please, that these patches should be implemented after integration-independent-modules-1390872-15.patch

Samvel’s picture

StatusFileSize
new17.03 KB
PASSED: [[SimpleTest]]: [MySQL] 159 pass(es).
[ View ]
new17.82 KB
PASSED: [[SimpleTest]]: [MySQL] 159 pass(es).
[ View ]

Small fixes in delete function.

Not forget please, that these patches should be implemented after integration-independent-modules-1390872-15.patch

hass’s picture

Issue summary:View changes

Could we split this into seperate issues, please?

Samvel’s picture

Hi Alexander,

Why you showed me old patches?
Should i move taxonomy and beans in other tasks? And in this task we keep "integration-independent-modules" ?

hass’s picture

Let's make this the taxonomy case here and move bean to an extra case. I only hided outdated patches. See issue summary.

Samvel’s picture

hass’s picture

Title:Taxonomy, Beans, Users integration» Taxonomy integration

Have you seen #2060243: Split linkchecker_scan_nodetypes as content type specific? I plan to move setting to conent type settings. Maybe we can add the vertical tab to taxonomy settings page, too.

Samvel’s picture

Ok, i will prepare new patch, for taxonomy only (seems good idea split settings)

sirchaox1224’s picture

Applying #15 and then #19 appears to be working beautifully for taxonomy integration. Thanks!