When using current level as the top level, please add an option to hide siblings of the current level.
Given a tree:

Item 1
  Item 1.1
    Item 1.1.1
    Item 1.1.2
  Item 1.2

When viewing contents of 1.1, the Item 1.2 should be hidden using that option.

Files: 
CommentFileSizeAuthor
#9 hide_siblings-1390526-9.patch9.08 KBsaitanay
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch hide_siblings-1390526-9.patch. Unable to apply patch. See the log in the details link for more information. View

Comments

adamdicarlo’s picture

Status: Active » Closed (duplicate)
Rob230’s picture

It's not a duplicate of that. Hiding the siblings is different to hiding the children of siblings.

For example, I need to be have a menu tree like this:

Item 1
  Item 1.1
  Item 1.2
Item 2
  Item 2.1
  Item 2.2
Item 3
  Item 3.1

Hiding the children of siblings would result in this:

Item 1
Item 2
  Item 2.1
  Item 2.2
Item 3

Hiding the siblings would result in this:

Item 2
  Item 2.1
  Item 2.2

I can't see any option to achieve this. If you want your menu to show Item 2, it will also show siblings of Item 2 (Item 1 and Item 3). If you start your menu from Item 2, it will only show children of Item 2, and not Item 2 itself.

The closest you can get is to show the title and make it a link, then use CSS to make it look like a menu item and to alter the other menu items to look like they are children of the title.

rikki_iki’s picture

Issue summary: View changes
Status: Closed (duplicate) » Needs review
FileSize
4.67 KB

The attached patch will give you an option to hide the siblings of all menu items in the active trail.
Example, if the active item is 1.1.2, the menu will show:

Item 1
  Item 1.1
    Item 1.1.2
      Item 1.1.2.1
      Item 1.1.2.2

Where Item 1.1.1, Item 1.2 and Item 2 exist but are not rendered .

rikki_iki’s picture

FileSize
5.24 KB

#3 had a line missing sorry, this one works better.

rikki_iki’s picture

FileSize
5.74 KB

The last patch still wasn't working properly. The attached is better.

timdavison’s picture

I had trouble applying the patch, I got the following error: patch: **** malformed patch at line 98: + if ($config['hide_siblings']) {
However I applied the patch manually and it worked fine for me.

saitanay’s picture

FileSize
4.46 KB
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es). View

Looks like this module has changed a lot since the earlier patch was created. Hence the patch would no more apply.

Recreated the patch based on the latest module. The functionality from the attached patch works as expected.

Every block now comes with a "Hide Siblings" option and when selected the siblings are hidden.

rv0’s picture

Status: Needs review » Needs work

Patch works fine, could use some work though:

- whitespace issues:
hide_siblings-1390526-7.patch:53: trailing whitespace.
hide_siblings-1390526-7.patch:67: trailing whitespace.
hide_siblings-1390526-7.patch:91: trailing whitespace.
warning: 3 lines add whitespace errors.

- code style:
looking at the patch, the code of the last code block in submit function could use some re-alignment.

- user interface:
the siblings option appears in "basic options", should be only shown in "advanced options"

saitanay’s picture

FileSize
9.08 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch hide_siblings-1390526-9.patch. Unable to apply patch. See the log in the details link for more information. View

Cleaner one.

Changes:
Whitespace issues, Moved the config to Advanced Section from Basic.

rv0’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 9: hide_siblings-1390526-9.patch, failed testing.

codevoice’s picture

Confirming that patch in #7 works as expected, thanks!