If hs_menu is active, you can't add menu items to a menu that doesn't have any menu items yet, using the menu admin form at admin -> structure -> menus -> list links -> add link .

This is due to the fact that menu_get_names(), called in hs_menu_hierarchical_select_valid_item(), gets the menu names from the menu_links table. The function will be removed in D8 in favour of menu_get_menus(), see http://drupal.org/node/784856.

CommentFileSizeAuthor
#1 hs_menu-cant_add_menu_items_to_empty_menu-1388308-1.patch486 bytesfirebird
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

firebird’s picture

firebird CreditAttribution: firebird commented
Status: Active » Needs review
FileSize
hs_menu-cant_add_menu_items_to_empty_menu-1388308-1.patch486 bytes

Here's a patch that makes hs_menu_hierarchical_select_valid_item() call menu_get_menus() instead.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Needs review » Needs work 
+++ b/modules/hs_menu.module
@@ -160,7 +160,7 @@ function hs_menu_hierarchical_select_valid_item($item, $params) {
-  $valid = (in_array($parts[0], menu_get_names()));
+  $valid = (array_key_exists($parts[0], menu_get_menus()));

suppose isset() a bit better

$all_menus = menu_get_menus();
$valid = isset($all_menus[$parts[0]]);
firebird’s picture

firebird CreditAttribution: firebird commented

I think (can't remember, though) that I used array_key_exists for a reason. If $parts[0] is set to NULL, isset() will return FALSE, whereas array_key_exists() will return TRUE.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented

I'm not sure that menu_get_names() returns a keyed array.

But checking for NULL inside array seems useless

Road Kill’s picture

Road Kill CreditAttribution: Road Kill commented

Thanks for the patch Firebird I tried the patch but now I am getting

Notice: Undefined variable: parts in hs_menu_hierarchical_select_valid_item() (line 166 of C:\wamp\www\mysite\sites\all\modules\hierarchical_select\modules\hs_menu.module).

Any ideas anybody

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Priority: Normal » Minor
Status: Needs work » Fixed

@firebird: thanks! Perfect one-liner :) I also read #784856: Menu_get_names() is dead code, remove it and commented on menu_get_names()' docs: http://api.drupal.org/api/drupal/includes%21menu.inc/function/menu_get_n....

Commit: http://drupalcode.org/project/hierarchical_select.git/commit/4b88100.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

xbery’s picture

xbery CreditAttribution: xbery commented

This issue is actually still active. Sorry to reopen this but I had to manually patch the hs_menu.module file. Could the patch mentioned in #6 be committed in next release? It works great.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented

It has been committed. No new release has been tagged though.

xbery’s picture

xbery CreditAttribution: xbery commented

Yep I realised that the moment I posted this comment :-) Though it makes it harder for us who use this great module :-) I really appreciate the work that has been made but issues as serious as this must be fixed when solution is known and agreed to. Just my opinion :-)

(I got really scared when I couldn't save any menu item)

xbery’s picture

xbery CreditAttribution: xbery commented
Issue summary: View changes

Specified where the adding of menu links doesn't work.