Lightbox callbacks uncacheable [#1387912]

Media gallery takes over the page deliver callback for lightbox paths, but media_gallery_lightbox_page_deliver() doesn't call drupal_page_footer(), so these callbacks can't use the page cache.

I'm not sure why drupal_page_footer() wouldn't be called here, so the attached patch adds this.

Comment	File	Size	Author
#3	media_gallery-add-page-cache-1387912-3.patch	471 bytes	msonnabaum
	media_gallery-add-page-cache.patch	466 bytes	msonnabaum

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Moloc CreditAttribution: Moloc commented 28 December 2011 at 22:34

Status:

Needs review

» Needs work

Having a look into the two functions drupal_page_footer() and drupal_exit(), it seems, that this patch needs some more work?

Both functions execute the following lines:

 module_invoke_all('exit');
  drupal_session_commit();

For example, using the core statistics module, and the "access log" option is activated, the module will create two log entries, because hook_exit is executed two times in one page request.
Therefore i assume, this patch needs work.