in the function entity_translation_admin_paths you are overwriting the normal translation module's admin path settings however you are not using the check if (variable_get('node_admin_theme')) { so it forces the translation page onto the admin theme always even if you have it set to use the front theme for content editing.

CommentFileSizeAuthor
#5 admin-theme-fix-1377542-5.patch1.59 KBbforchhammer
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Daemon_Byte’s picture

Also in the entity info alter array you are hard coding the admin theme there also in $entity_info[$entity_type]['translation']['entity_translation']['theme arguments']

timofey’s picture

+1 Subscribing

can we just change line 101 of entity_translation.module
from
'theme arguments' => array('admin_theme'),
to
'theme arguments' => array('default_theme'),

AdamGerthel’s picture

Component: Code » Base system

I've stumpled upon this as well. Paths such as "node/X/translate" and "node/X/translate/add/X/X" shouldn't be using the administration theme when the administration is explicitly set to not be active when editing content. It also seems as if other theme manipulation modules such as Theme Key are unable to override the theme on those paths.

bforchhammer’s picture

Title: always using the admin theme » Do not always use the admin theme

Marked #1770272: Respect admin theme setting: "use the administration theme when editing or creating content" as duplicate. Note that that issue contains a mini-patch for the problem of the OP, but it looks like we need a new one which also removes the 'theme arguments' key!?

bforchhammer’s picture

Status: Active » Needs review
FileSize
1.59 KB

Here's a new patch which...

  • correctly specifies admin paths based on the "edit path" key in entity info
  • respects the "use administration them when editing or creating content" setting
  • removes the hard coded 'theme arguments' thing (seems to be a left-over from very early code)
Erik.Johansson’s picture

Got the same problem and the patch doesn't fix my problem.. The entity translation page is stuck using admin theme even if we are using theme key. Any updates on this?

bforchhammer’s picture

You may have to clear your (menu) cache once...

plach’s picture

Status: Needs review » Fixed

Committed and pushed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit a19b6aa on 7.x-1.x, et-permissions-1829630, factory, et-fc, revisions authored by bforchhammer, committed by plach:
    Issue #1377542 by bforchhammer | Daemon_Byte: Fixed Do not always use...

  • Commit a19b6aa on 7.x-1.x, et-permissions-1829630, factory, et-fc, revisions, workbench authored by bforchhammer, committed by plach:
    Issue #1377542 by bforchhammer | Daemon_Byte: Fixed Do not always use...