Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This patch corrects the following issues:
- $may_cache is no longer used in hook_menu()
- the $form_id, $form_values parameters have gone away in favour of $form and &$form_state (the data previously in $form_values is now stored $form_state['values'])
- The submit form has been changed to use a submit button instead of system_settings_form() as the module has its own submit function that sets the variables
Misc. other coding style changes as per recommendations by the Code Review module
- Eliminated use of tabs in favour of two spaces
- Empty lines should not be indented
Comment | File | Size | Author |
---|---|---|---|
#1 | fix-d5-leftovers-1376892-1.patch | 11.42 KB | stewart.adam |
Comments
Comment #1
stewart.adam CreditAttribution: stewart.adam commentedComment #2
mattcasey CreditAttribution: mattcasey commentedThanks for this. There's one typo, an extra '$' I found in your patch:
Comment #3
stewart.adam CreditAttribution: stewart.adam commentedOops, sorry about that!
Comment #4
Simon Georges CreditAttribution: Simon Georges commentedChanging status, as there is a patch.