page-title d7 upgrade issue

After upgrading from D6 to D7 via Drush, Page Title displayed the token pattern code rather than text in page titles; i.e., the page title was shown literally as [page-title] | [site-name] rather than the actual page title | site name. Apparently Page Title/Token syntax has changed between D6 and D7 and the syntax was not updated automatically on site upgrade; D6 [page-title] is now D7 [current-page:page-title] and [site-name] is now [site:name].

It took me quite some time to realize why page titles weren't being displayed correctly; I hope this behavior can be corrected or documented prominently to ease the upgrade process.

CommentFileSizeAuthor
#4 page_title-install-token-update-1376832-4.patch1002 bytesmrf
#2 page_title-install-token-update-1376832.patch1.1 KBmrf
drupal-page-title-d7-upgrade-issue.png120.4 KBforbesconrad
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nicholasThompson’s picture

nicholasThompson
Primary language English
CreditAttribution: nicholasThompson commented
Title: Page Title token syntax not updated in site upgrade from D6 to D7 » Page Title Upgrade from D6 to D7 - replace tokens with new syntax.
Status: Active » Postponed

This is an important thing to add to the update - however it'd be very difficult to cover ALL tokens (in a FROM -> TO array map)..

mrf’s picture

mrf CreditAttribution: mrf commented
Version: 7.x-2.5 » 7.x-2.x-dev
Status: Postponed » Needs review
FileSize
page_title-install-token-update-1376832.patch1.1 KB

Did some research and it looks like token has already solved the hard part in it's own upgrade path.

mrjmd’s picture

mrjmd CreditAttribution: mrjmd commented
Status: Needs review » Needs work

Thanks for this patch! It seems to work, although I did have to remove the following line as it was throwing a 'cannot redeclare' error on update.php:

include(drupal_get_path('module','token') . '/token.install');

mrf’s picture

mrf CreditAttribution: mrf commented
Status: Needs work » Needs review
FileSize
page_title-install-token-update-1376832-4.patch1002 bytes

Guess that line wasn't needed for whatever reason those install functions weren't available when I was working on it...

Here's an update.

amitgoyal’s picture

amitgoyal CreditAttribution: amitgoyal commented
Status: Needs review » Reviewed & tested by the community

@mrf - looks good to me.

GiorgosK’s picture

GiorgosK
Location Chios, Greece 🇬🇷
CreditAttribution: GiorgosK commented

works as advertised
please commit

yan’s picture

yan CreditAttribution: yan as a volunteer commented
Issue summary: View changes

Patch from #4 works fine for me too. Thanks! Commit would be nice after three years.