Using pressflow 6.22 with E_NOTICE on, I get

Only variables should be passed by reference
      line 13


jessehs’s picture

Bump... I'm seeing this too. Same conditions.

jaapjan’s picture

kenianbei’s picture

Status: Active » Needs review

Same issue here, patch removed warning.

jessehs’s picture

Status: Needs review » Reviewed & tested by the community
joelpittet’s picture

Version: 6.x-1.0 » 6.x-1.x-dev
Issue tags: +Quick fix

Thanks @jaapjan that patch works, possibly consider this one too it may be slightly faster:

Either way this is still RTBC.

roball’s picture

Issue summary: View changes

Can confirm that the patch eliminates the PHP error under PHP 5.4. However, it doesn't seem that it ever gets committed.

DamienMcKenna’s picture

Issue tags: -PHP 5.3 compatibility. pressflow +PHP 5.4, +PHP 5.3