So the worst thing that can happen on a contact for is to tell the sender their message was sent, and not send it.

I configured the form accidentally to do this by enabling text processing for the contact form, but not checking "Text analysis" for spam or profanity or checking any fields to analyse. I don't remember if these were the defaults, or I unchecked them.

Anyways, in this state, I got the following warnings and a false positive message:

warning: Invalid argument supplied for foreach() in /var/aegir/hostmaster-6.x-1.6/sites/all/modules/contrib/mollom/mollom.module on line 1059.
warning: implode(): Invalid arguments passed in /var/aegir/hostmaster-6.x-1.6/sites/all/modules/contrib/mollom/mollom.module on line 1707.
Your message has been sent.

Either the config form should prevent this configuration, or the module should not throw warnings and a false message.

Thanks!

Mike

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Title: Warnings and false postive ("Your message has been sent") » Form protection with text analysis saved without enabled fields
Status: Active » Postponed (maintainer needs more info)

The module already prevents from saving a text analysis configuration without enabled fields.

This is actually covered by functional tests already. Can you manually reproduce this?

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)

It's been some time since the last update here. I'm going to close this ticket for now, as I hope that the issue is resolved.

Please feel free to reply if I'm mistaken or if you have additional questions.

Thanks for your feedback!