Problem/Motivation

I have no idea how, but I have found several times that the checkmarks for menu items under the menu item visibility tab are spontaneously reset, opening up this menu item for all users.

I would like to provide more debug info, or even a way to reproduce this, but I haven't yet figured out where to look. No errors or notices in my log. I will add more feedback if I come across anything.

Steps to reproduce from #5

To reproduce, simply configure a menu item and limit it to a specific role. Save. Then, move the item so that it becomes a parent or child of another menu item in the hierarchy. Save. The visibility settings will be reset.

CommentFileSizeAuthor
#25 settings_are_reset_when-1369480-25.patch866 bytesjoelpittet
#7 menu_item_visibility-fix_for_roles_being_reset_when_moving_menu_items-1369480.patch1.29 KBAnonymous (not verified)
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

daniel_d’s picture

daniel_d CreditAttribution: daniel_d commented

This small module is very useful.

Though I experience possibly the same problem described here while changing a node which already has a menu item edited with roles set by this module. The result is that a new menu item, with the same name, is created and both have lost their checkmarks.

I presume that the content editor doesn't recognise the menu item anymore (therefor creating a new one). This might also be a hint toward the problem of the lost checkmarks.

kingfisher64’s picture

kingfisher64 CreditAttribution: kingfisher64 commented

Would like to use this handy little mod instead of http://drupal.org/project/menu_per_role however this looks like it just needs a bit of fine tuning. Has any progress been made with this issue?

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Priority: Major » Normal
Status: Active » Postponed (maintainer needs more info)

Well I haven't ever been able to duplicate this and comment #1 indicates that something else might be going on that doesn't necessarily mean this module has a bug. It would be helpful if someone could reproduce this issue with a fresh install of Drupal core only plus this module.

kingfisher64’s picture

kingfisher64 CreditAttribution: kingfisher64 commented

Right so there's a ghost in the machine somewhere else. Will bear that in mind when viewing bugs in general within drupal mods.

Thanks Dave for taking the time to reply.

ptmkenny’s picture

ptmkenny CreditAttribution: ptmkenny commented
Status: Postponed (maintainer needs more info) » Active

I was able to reproduce this from a fresh install of Acquia Drupal.

To reproduce, simply configure a menu item and limit it to a specific role. Save. Then, move the item so that it becomes a parent or child of another menu item in the hierarchy. Save. The visibility settings will be reset.

ptmkenny’s picture

ptmkenny CreditAttribution: ptmkenny commented
Title: Settings are sometimes reset - all checkmarks gone » Settings are reset when items are moved in the menu hierarchy
Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Component: User interface » Code
Status: Active » Patch (to be ported)
FileSize
menu_item_visibility-fix_for_roles_being_reset_when_moving_menu_items-1369480.patch1.29 KB

I was having the same problem, I fixed it with a simple check before deleting the role information in _menu_item_visibility_menu_link_update($link).

The proper fix would be to see why $link doesn't get the roles attribute added when moving a menu item. It works fine for editing a menu item.

exode785’s picture

exode785 CreditAttribution: exode785 commented

Thank you, is good for me !

xaa’s picture

xaa CreditAttribution: xaa commented

hello,
I had the same issue with links created by taxonomy_menu (default visibility setting after node update).

patch #7 working. Thank you.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
CreditAttribution: mkalkbrenner commented
Status: Patch (to be ported) » Reviewed & tested by the community

just updated the status to the correct value.

retiredpro’s picture

retiredpro CreditAttribution: retiredpro commented

#7 worked against the latest dev release for me. Thank you.

massiws’s picture

massiws CreditAttribution: massiws commented

#7 works fine also in 7.x-1.0-beta1 release.
Thank you!

drupix’s picture

drupix
Primary language French
Location Geneva, 🦊🇨🇭
CreditAttribution: drupix commented

I had the same problem when saving a node who has a menu item.
#7 and 7.x-1.0-beta1 worked
Thank's

ngreenup’s picture

ngreenup CreditAttribution: ngreenup commented

I had the same problem. The patch in comment #7 worked for me.

NancyDru’s picture

NancyDru
she/her/hers
Primary language English
Location Boston
CreditAttribution: NancyDru commented
Issue summary: View changes

Can we get this committed, please?

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

Thank you for the patch #7.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
CreditAttribution: legolasbo commented

marked #2318139: Must save "Show menu link for specific roles" setting twice for it to work as a duplicate.

unqunq’s picture

unqunq CreditAttribution: unqunq commented

The patch in comment #7 worked for me. Thanks.

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
CreditAttribution: ergonlogic commented
Priority: Normal » Critical

I've seen this behaviour occur when simply saving a node that is providing a menu item. Even without any changes to the node in question, the associated visibility settings are lost on the menu item. The patch in #7 appears to have resolved the issue.

I'm bumping the priority to critical, since this bug causes loss of data (the menu visibility settings themselves) and exposes security vulnerabilities (menu items become visible to roles that ought not see them). Admittedly, this is arguable, especially since this module doesn't pretend to secure access to path or anything...

hkovacs’s picture

hkovacs CreditAttribution: hkovacs as a volunteer commented

#7 in 7.x-1.0-beta1 works for me.

kubrt’s picture

kubrt CreditAttribution: kubrt commented

#7 in 7.x-1.0-beta1 works for me too. Have also been getting this behaviour when simply saving a node that is providing a menu item.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Version: 7.x-1.0-beta1 » 7.x-1.x-dev
Issue tags: +Needs issue summary update

Changing to the branch it will be applied to. There are no automated tests on the module but steps to reproduce this would be nice to add to the issue summary.

NancyDru’s picture

NancyDru
she/her/hers
Primary language English
Location Boston
CreditAttribution: NancyDru commented

See #5.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Issue summary: View changes
Issue tags: -Needs issue summary update

Thanks, added to issue summary

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
FileSize
settings_are_reset_when-1369480-25.patch866 bytes

Re-rolling to test

  • joelpittet committed b377381 on 7.x-1.x 
    Issue #1369480 by joelpittet, Karel Bemelmans: Settings are reset when...

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Status: Reviewed & tested by the community » Fixed

Tested and yup it does fix the issue. I've committed it to dev. Thank you all for helping resolve this issue.

Sorry messed up the commit message/attribution, that's why there is two commits

NancyDru’s picture

NancyDru
she/her/hers
Primary language English
Location Boston
CreditAttribution: NancyDru commented

Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.