Mailhandler cannot assign emailed content to group

where's the patch :)

there is some (interesting) extraneous code in og_nodeapi() in the patch. what are you up to :).

i would actually like to attack this differently. i want to make it possible to use associative arrays in mailhandler commands. the syntax for that should be the identical as our .info files. for example, see the $region example at http://drupal.org/node/171205.

so, at the beginning of mailhandler_process_message() we should actually write the contents of the commands variable along with any commands in the email to the temp dir and then pass that filename to drupal_parse_info_file() which will hand back the $data array we need. then we merge with $node and proceed.

AFAICT, the .info syntax is backwards compatible with what we have now so no update is required. nice.

i think that would be a good improvement for core, but it should not slow down my patch. retrieving messages is a seldom operation and we only have to write the commands once per retrieve so performance is a non issue.

no, we have .info in 5 as well. i don't expect any changes for 4.7

watching

Is this patch applied to the latest release of OG?

OK. Been at this for more than a few hours now. Trying to get mailhandler to work in D6. Using the og_groups: [x] command was not working until I commented out the line as per the patch above. I am trying to understand what is happening in this function from the latest D6 version of og.module:

function og_presave_group(&$node) {
  if (!empty($node->og_groups_inaccessible)) {
    // Add the inaccessible groups which did not show in Audience selector
    $node->og_groups = (array)$node->og_groups + $node->og_groups_inaccessible;//note 1
  }
  
  /**
   * Change $node->theme to $node->og_theme so it matches node_load(). The node form uses $theme, not $og_theme.
   * If author chose the default theme, then '' is written to DB and group follows changes made by site admin.
   */
  if (isset($node->theme)) {
    $node->og_theme = $node->theme;
  }
  else {
    $node->og_theme = NULL;
  }
  
  // Normalize og_groups array
  if (isset($node->og_groups)) {
    $node->og_groups = array_filter($node->og_groups);//note 2
    //$node->og_groups = array_keys($node->og_groups);//note 3
  }
  
  // Support devel module's bulk node generation.
  // Affiliate group posts with group(s). Also populate special group fields.
  if (isset($node->devel_generate)) {
    og_devel_generate($node);
  }
}

Note 1: It seems we are using short hand to cast an objects properties to an array and merge at same time?
Note 2: Then filter the array against what we set earlier, which appears to be designed to remove null values?
Note 3: This is the line that gets commented out so we return values and get it to work with mailhandler.

Sorry if these are such stupid questions but it's late and I am really trying to grok this function.

I know Moshe has plans to work this another way but if this fix works and does not cause unintended consequences it could be a good way for a bunch of us to get by in the short term.

Thoughts please.
Thanks,
Coby

changing it to ANMI since I also changed the version to 6. I will create a patch if I can get some confirmation on the implications of the above fix. I have already tested it and know it works in the mailhandler use case.

Here is what I have so far:

presave is the new submit. It allows a better workflow for modules to perform action(s) prior to save.

if (!empty($node->og_groups_inaccessible)) {
    // Add the inaccessible groups which did not show in Audience selector
    $node->og_groups = (array)$node->og_groups + $node->og_groups_inaccessible;
  }

This is for a node that may have multiple groups (audiences); some of which may not be available to the current user. This should not be the case for Mailhandler as you will only be allowed to save a node if you have permissions to the group declared in the email command. This is more of an issue on update, so perhaps we have issues if someone is trying to use the subject line to edit the node.

  // Normalize og_groups array
  if (isset($node->og_groups)) {
    $node->og_groups = array_filter($node->og_groups);

Is useful to get rid of null values. Should not have any if we are using mailhandler. But I guess it's possible.

    $node->og_groups = array_keys($node->og_groups);
  }

This is the problem line. As mentioned by @struesda above the keys in this array are not going to be helpful - we want the values. So, was this a way to make sure we have the correct number of dimensions for the object properties? Is this a problem in the way Mailhandler is passing og_groups? Or is this a bug in OG that needs to be patched?

Thanks,
Coby

line 1447 in og.module

//$node->og_groups = array_keys($node->og_groups);

still needs to be commented out to get mailhandler to work with og

Mailhandler to og is working for me in 6.9 with the commented out array_keys line, described above. However, all new messages processed by mailhandler are being flagged as Public. Is there a mailhandler command I can use to change this?

Yep, just did it myself and it seems to be working. Has anyone figured out why that line needs to be in there?

subscribe

Adding a mailhandler command

og_public: 0

seems to work for me.

I'm using the following code to set the group IDs as both the key and value of the array, which is how OG likes it to be.

The code I'm using so far is this - you could put it in mymodule_mailhandler() if that makes more sense to you.

/**
 * mailhandler assigns the values set with og_groups: [1,12,123] as 
 *
 *   $node->og_groups = array( 1, 12, 123 ) ;
 *
 * however, og wants these values to have the gid as the key and value, eg
 *
 *   $node->og_groups = array( 
 *                        1   => 1,
 *                        12  => 12,
 *                        123 => 123 
 *                      ) ;
 *
 */
function og_mailhandler($node, $result, $i, $header, $mailbox) {
  if ( isset($node->og_groups) && is_array($node->og_groups) ) {
    $node->og_groups = array_combine($node->og_groups, $node->og_groups));
  }
  return $node ;
}
 

EDIT: do not use the patch attached to this comment - it contains a typo, re-posting fixed version in next comment ...

fixed typo, pls review

has development of this module halted? sounded very promising.

OG is now relying on notifications for messages, I'll need to better understand what the patch is trying to accomplish that can be already done.
Also please re-roll patch after fixing coding standards -- http://drupal.org/coding-standards

@amitaibu,
It's been awhile since I have touched any of this code, but when I was active on this issue it was all about inbound mail; thus the Mailhandler in the title. I was using Messaging and Notifications for outbound, but to establish two way email communications for OG you need Mailhandler to process incoming emails (unless that has changed, but I do not think it has) along with what used to be Mail2Web for comment threading when I worked on it.

The issue, in review, is that Mailhandler was passing an array to the above function with the value used in the Mailhandler command that sets the node->og_groups for the mail that will become a post. So each group could have it's own email address to make posts to that group. But og_presave eventually sets the node->og_groups using the keys as values. And I have never been able to figure out why - the comment says it's to "Normalize the array". @grobot describes it well in #20 but I am not sure if his patch is needed since it's fixed if we just comment out the offending line that attempts to set the array values using keys. Still a big mystery to me.

Commenting the line out as in #15 has never caused me any issues on sites running several other contrib modules, but there may be issues with other modules that I do not use that also run through the og_presave function???

R,
C

Hey guys. Running into the issue above. Trying to have Mailhandler automatically add emails to OG forums and not having any luck. The node gets created, is a forum entry, but doesn't go to the OG forum no matter what I use (tid:, og_group:[], og_groups: []) and even tried commenting out the line above. Unless I'm supposed to do anything special after commenting tha out (clear cache, restarted, etc??), it didn't work. Is there a way to make this work with OG 2?

Thanks!

i'm looking for the same thing, would find this indespensible!

In general mailhandler kind of stuff is being handled in dedicated modules. If those modules need a specific feature or bugfix, a new issue please.