Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.In #503264: Limit the total number of submissions, we added total submission limit in addition to the existing per-user limit. However now we have a bunch of functions and variables named "submission_limit" which refer to the "per-user" limit, then other functions/variables named "total_submission_limit". It's confusing that the generic term is used to refer to the per-user limit and we should go through and update these functions and variables for consistency.
Attached are first passes at consistency changes.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | webform_user_limit_cleanup-d6.patch | 6.45 KB | quicksketch |
| #1 | webform_user_limit_cleanup-d7.patch | 6.83 KB | quicksketch |
| webform_user_limit_cleanup-d6.patch | 5.72 KB | quicksketch | |
| webform_user_limit_cleanup-d7.patch | 6.17 KB | quicksketch | |
Comments
Comment #1
quicksketchUpdating a few more instances in hook_theme() and in theme function calls. In #503264: Limit the total number of submissions I mentioned that the change broken existing theming of theme_webform_view_messages(), but only in D6. After these changes, the D7 theming also needs to be updated. However considering users that *don't* update their theming don't get any error message at all when the total limit is exceeded, I think this is fine. We really need a better way of adjusting user messages overall besides the theme system (or using the theme system in some other way).
Comment #2
quicksketchCommitted to both 3.x versions.
Comment #4
broonJust a note since I stumbled upon that: in the database webform table, it still says "submit_limit" and "total_submit_limit" (same for the interval columns).