Theme functions not found when using mobile_jquery as a subtheme [#1354410]

template.php loads the .inc files that contain the theme function overrides with the loop:

$modules = module_list();

foreach ($modules as $module) {
  if (is_file(drupal_get_path('theme', $theme_key) . '/includes/modules/' . str_replace('_', '-', $module) . '.inc')) {
    include_once(drupal_get_path('theme', $theme_key) . '/includes/modules/' . str_replace('_', '-', $module) . '.inc');
  }    
}

When using the mobile_jquery as a base theme, the $theme_key global refers to the subtheme which does not contain the .inc files. I'm not sure why you are using $theme_key and not just make the loop like below, which does work with subthemes.

foreach ($modules as $module) {
  if (is_file(dirname(__FILE__) . '/includes/modules/' . str_replace('_', '-', $module) . '.inc')) {
    include_once(dirname(__FILE__) . '/includes/modules/' . str_replace('_', '-', $module) . '.inc');
  }    
}

Comment	File	Size	Author
#3	mobile_jquery-fix-subtheme-module-inclusions-1354410.patch	1008 bytes	charlietoleary
#1	mobile_jquery-fix-subtheme-module-inclusions-#1354410.patch	1008 bytes	charlietoleary

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

charlietoleary CreditAttribution: charlietoleary commented 20 February 2012 at 02:44

File	Size
mobile_jquery-fix-subtheme-module-inclusions-#1354410.patch	1008 bytes

I suggest that drupal_get_path() be used over dirname(__FILE__).

Rather than referencing the global $theme_key it should be safe to just enter the theme name as a string:

foreach ($modules as $module) {
  if (is_file(drupal_get_path('theme', 'mobile_jquery') . '/includes/modules/' . str_replace('_', '-', $module) . '.inc')) {
    include_once(drupal_get_path('theme', 'mobile_jquery') . '/includes/modules/' . str_replace('_', '-', $module) . '.inc');
  }    
}

patch attached.

This should probably also be applied to the lines just above this snippet, which also use the dirname(__FILE__) method:

include_once(dirname(__FILE__) . '/includes/mobile_jquery.inc');
include_once(dirname(__FILE__) . '/includes/modules/theme.inc');
include_once(dirname(__FILE__) . '/includes/modules/pager.inc');
include_once(dirname(__FILE__) . '/includes/modules/form.inc');

Although they appear to be working fine so I wont tinker with them.