EntityFieldHandlerHelper: Add html-list output to "List-handling" [#1352454]

Problem/Motivation

The List-handler of EntityFieldHandlerHelper doesn't provide a posibility to generate a html-list.
Would be nice to have such an option - especially to build views.

Proposed resolution

Add such a handler. Please see the attached patch for a possible solution.

Remaining tasks

Review patch.

User interface changes

New option "Output values as list" in "List-handling".
New setting "List type" if "Output values as list" is selected.

API changes

none.

Comment	File	Size	Author
#3	entity-EntityFieldHandlerHelper-add-html-list-output.patch-1352454-3.patch	4.8 KB	das-peter
#3
	entity-EntityFieldHandlerHelper-add-html-list-output.patch	4.18 KB	das-peter

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

das-peter CreditAttribution: das-peter commented 26 November 2011 at 10:48

Issue tags:

+dvcs11

Added Views sprint tag.

Comment #2

fubhy CreditAttribution: fubhy commented 20 February 2012 at 16:02

Status:

Needs review

» Needs work

+++ b/views/handlers/entity_views_field_handler_helper.incundefined
@@ -420,20 +433,32 @@ class EntityFieldHandlerHelper {
+          return theme('item_list', array(
+            'items' =>  $inner_values,

There are 2 whitespace characters in the 'items' line (behind the arrow).

Other than that it looks okay. Just need to see what fago thinks about it. :)

Comment #3

das-peter CreditAttribution: das-peter commented 21 February 2012 at 10:24

Status:

Needs work

» Needs review

File	Size
entity-EntityFieldHandlerHelper-add-html-list-output.patch-1352454-3.patch	4.8 KB

Here we go, re-rolled and fixed also other coding standard violations in the existing code.

Comment #4

21 February 2012 at 10:27

Status:	Needs review	» Needs work
Issue tags:	-dvcs11

The last submitted patch, entity-EntityFieldHandlerHelper-add-html-list-output.patch-1352454-3.patch, failed testing.

Comment #5

das-peter CreditAttribution: das-peter commented 21 March 2012 at 16:27

Status:	Needs work	» Needs review
Issue tags:		+dvcs11

#3: entity-EntityFieldHandlerHelper-add-html-list-output.patch-1352454-3.patch queued for re-testing.

Comment #6

fago

German

Vienna

CreditAttribution: fago commented 25 May 2012 at 20:43

Status:

Needs review

» Fixed

Sry for the late review.

+++ b/views/handlers/entity_views_field_handler_helper.inc
@@ -6,7 +6,8 @@
- * Helper class containing static implementations of common field handler methods.
+ * Helper class containing static implementations of common field handler
+ * methods.

The first line actually may be longer than 80 chars, but should not break. So let's keep it as it was.

Except for that, patch looked good. Committed it, thanks.