I noticed that tha table themed admin interface for table style output was very difficult to follow, too wide and too not fit for the views admin interface, so attached is a, IMHO, more inline with views admin interface.

First of all, I fixed "collapsable" for "collapsible" as that's the correct FAPI attribute.

Then I put all the field table options in a fieldset and have that not collapsed. Then have all of the other settings per fields collapsed except for the position settings.

I also did something similar to the unformatted field settings, although this one was actually more into this line of things, so I mostly give both a similar look and feel for the configuration settings.

I also removed the theme function for styling this and hence, the viuews_pdf.admin.inc.

Will submit patch now.

#1 1349442-1-better-admin-interface.patch11.69 KBhanoii
Members fund testing for the Drupal project. Drupal Association Learn more


hanoii’s picture

Status: Active » Needs review
11.69 KB
Simon Georges’s picture

Status: Needs review » Needs work

As I committed patch from #1270346-1: collapsable should be collapsible (Typing error) (smaller patch, easier to review / commit), this needs a re-roll. I'll handle it if nobody does before ;-)

Simon Georges’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Needs work » Patch (to be ported)
killua99’s picture

Status: Patch (to be ported) » Reviewed & tested by the community

Exist a patch to handle this issues and others. Please see #2032189: Multiple issue fixing in a single patch and review others issues patch.

This is RTBC, and ready to apply.

killua99’s picture

Priority: Normal » Major
Status: Reviewed & tested by the community » Needs work
Issue tags: +accepted feature request
killua99’s picture

Priority: Major » Normal
Issue tags: +#views_pdf_7.x-2.x

Tagging for the next version.

killua99’s picture

Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Needs work » Active
killua99’s picture

Issue summary: View changes
vegansupreme’s picture

I think this was fixed a while ago with #2032189: Multiple issue fixing in a single patch
All of the changes mentioned in the OP have been included into the module for a long time now.
If we want to update the UI for V2, what specifically should change? Should this be a new issue?

killua99’s picture

Eh yes, this will need a new issue. But will be under "i+d" label with low priority tho