Problem/Motivation
The code shouldn't throw any error/warnings/notices.
Currently the module throws following strict warning (tested with latest views-dev):
Strict warning: Declaration of entity_views_plugin_row_entity_view::pre_render() should be compatible with that of views_plugin_row::pre_render() in require_once() (Zeile 11 von modules/entity/views/plugins/entity_views_plugin_row_entity_view.inc).
Is the reference in entity_views_plugin_row_entity_view::pre_render(&$values) necessary?
Proposed resolution
If the reference isn't necessary we should remove it.
If a reference generally makes sense we could change the method signature in views itself?
Remaining tasks
Clarify if the reference is necessary.
User interface changes
none.
API changes
Possibly...
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | entity-fix-strict-warning-in-entity_views_plugin_row_entity_view-1347634-2.patch | 1.12 KB | das-peter |
Comments
Comment #1
fagoI don't think that's needed, so removing it should be fine.
Comment #2
das-peter commentedThanks for the feedback - the huge patch to remove it is attached now :D
Comment #3
fago:D
Thanks, committed!