If your site name is 'My Site', then the generated xhprof data file would look like '/tmp/xhprof/4ec53fd3bb4b2.My Site' but the xhprof reports look for '/tmp/xhprof/4ec53fd3bb4b2.My%20Site' due to URL encoding from the 'source' parameter. They're not the same, so the reporting breaks. I've attached a patch to strip spaces and apostrophes from the site name, which is used to generated the 'source' parameter used by xhprof reporting.
For the same reason I've changed the default in the variable_get() for the site name to be the string 'devel' instead of an empty string, so that reporting doesn't break for sites which for whatever reason don't have a site name variable defined.
(This is the first patch I've submitted so I'd appreciate knowing if I've done it the right way. I don't know how to use git so I generated this from my Eclipse IDE using SVN.)
|PASSED: [[SimpleTest]]: [MySQL] 0 pass(es). |
[ View ]
|devel.patch||1.18 KB||no longer here 793948|
|FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch devel_0.patch. See the log in the details link for more information. |
[ View ]