views_get_applicable_views() calls views_get_all_views(TRUE) -- there is no reason to reset all the time. Doing htis unnecessarily flushes a lot of caches and causes a great deal of unnecessary extra loading on every page load.

CommentFileSizeAuthor
#1 1342580.patch434 bytesk4v
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

k4v’s picture

k4v CreditAttribution: k4v commented
FileSize
1342580.patch434 bytes

I removed the parameter TRUE

k4v’s picture

k4v CreditAttribution: k4v commented
Status: Active » Needs review
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Fixed

This patch looks fine! Committed to 7.x-3.x

k4v’s picture

k4v CreditAttribution: k4v commented
Issue tags: +dvcs11

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein commented

This caused a regression in #1280382: Enabling disabled views presents a path to the new view which leads to 404, so I went ahead and reopened that issue.

Based on the discussion there, the performance impact of this was thought to have been negligible, as it seemed like views_get_applicable_views() is called rarely... Was that a mistake? At first glance, I'm not seeing how there is a performance hit on every page load from this, but I could be missing something.