Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
I think the grid overlay would make for a good module in the Accelerator package.
Pros:
- Expandability: additional grid tools, such as labels for regions (à la omega), would be a good fit for accelerator. It'd be more consistant to have these tools in one place.
- Reduces fusion_core footprint: production sites could disable the grid overlay from the modules page and its corresponding CSS/JS would never be loaded.
Cons:
- Instead of going to theme settings to turn on/off the grid overlay tool, user would presumably visit admin/appearance/fusion. Alternatively, perhaps accelerator could hook_form_alter() the theme settings from the module.
- The module would have an implicit rather than explicit requirement for a Fusion theme. It's possible that some users might enable the grid tool for a non-fusion theme and not understand why things aren't working.
Comments
Comment #1
esmerel CreditAttribution: esmerel commentedI think the cons are fairly minor and definitely documentable; this seems like a reasonable move to me. Tools are not necessarily something that belong in the core and if it's in accelerator, the possibility exists that someone could make it more compatible with other themes in drupal so that grid overlay would work on more of them.
Comment #2
stephthegeek CreditAttribution: stephthegeek commentedThumbs up from me!
Comment #3
Poieo CreditAttribution: Poieo commentedThis was moved to Accelerator some time ago.