Strict warning: Only variables should be passed by reference in custom_breadcrumbs_paths_form() (Line 274 of .../modules/custom_breadcrumbs/custom_breadcrumbs_paths/custom_breadcrumbs_paths.module).

I'm using PHP 5.3.8.

CommentFileSizeAuthor
#13 After.png59.63 KBrenatog
#13 Before.png14.37 KBrenatog
#6 custom_breadcrumbs-strict-warning-1338126-6.patch1.18 KBtanmayk
#5 1338126-5-strict-warning-in-custom-breadcrumbs-paths.patch1.18 KBtanmayk
#3 custom_breadcrumbs_paths.module.zip3.83 KBhoebekewim
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

acidpotato’s picture

acidpotato CreditAttribution: acidpotato commented

Same here..

kalis1’s picture

kalis1
Location Lyon
CreditAttribution: kalis1 commented

Same here too. This is happening when I set a Custom Breadcrumb for Path with a php callback like :

return my_custom_function();
hoebekewim’s picture

hoebekewim CreditAttribution: hoebekewim commented
FileSize
custom_breadcrumbs_paths.module.zip3.83 KB

At line 272 in custom_breadcrumbs_paths.module change as follow (notice the s behind $breadcrumb(s) !)

Original:

 if (isset($bid)) {
    drupal_set_title(t('Edit Custom Breadcrumb for Path'));
    $breadcrumb = array_pop(custom_breadcrumbs_load_breadcrumbs('custom_breadcrumbs_paths', NULL, array('bid' => $bid)));
 }

Fix:

 if (isset($bid)) {
    drupal_set_title(t('Edit Custom Breadcrumb for Path'));
    $breadcrumbs = custom_breadcrumbs_load_breadcrumbs('custom_breadcrumbs_paths', NULL, array('bid' => $bid));
    $breadcrumb = array_pop($breadcrumbs);
 }

Or replace it by using the uploaded file here.
It's just that simple ;)

rudiedirkx’s picture

rudiedirkx CreditAttribution: rudiedirkx commented

I'm so glad this is being worked on......

tanmayk’s picture

tanmayk
he/him
Primary language English
Location Maharashtra
CreditAttribution: tanmayk commented
Issue summary: View changes
Status: Active » Needs review
FileSize
1338126-5-strict-warning-in-custom-breadcrumbs-paths.patch1.18 KB

Attached patch against 2.x branch. Hope this will be fixed soon.

tanmayk’s picture

tanmayk
he/him
Primary language English
Location Maharashtra
CreditAttribution: tanmayk commented
FileSize
custom_breadcrumbs-strict-warning-1338126-6.patch1.18 KB

Patch against 2.0alpha3. I needed it for my make file. Might be helpful for someone.

jabberwooki’s picture

jabberwooki CreditAttribution: jabberwooki commented

It works for me, on 7.x-2.0-alpha3. Thanks for the patch file.

codi’s picture

codi CreditAttribution: codi commented
Status: Needs review » Reviewed & tested by the community

Works for me as well. Moving this issue to RTBC.

Sutharsan’s picture

Sutharsan CreditAttribution: Sutharsan commented

@colan, can we please get this committed. This is a no-brainer.

tanmayk’s picture

tanmayk
he/him
Primary language English
Location Maharashtra
CreditAttribution: tanmayk as a volunteer and at OSSeed Technologies commented

Is this being committed soon?

joshuautley’s picture

joshuautley CreditAttribution: joshuautley commented

This is happening in Version: 7.x-2.0-beta1 as well.

Christian DeLoach’s picture

Christian DeLoach CreditAttribution: Christian DeLoach commented

Like Joshua said, the problem was re-introduced in 7.x-2.0-beta1. The solution in #3 still works.

renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented
Assigned: Unassigned » renatog
Issue tags: +ciandt-contrib
FileSize
Before.png14.37 KB
After.png59.63 KB

Hi people.

I applied the patch and works good for me too.

Before:

After:

Thank you very much

  • RenatoG committed 5ec678d on 7.x-2.x authored by tanmayk 
    Issue #1338126 by tanmayk, RenatoG, hoebekewim, kalis1, rudiedirkx,...
renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented
Status: Reviewed & tested by the community » Fixed

Fixed.

Commited in dev branch.

Thank you all for contributions people.

Good Work.

Regards

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.