Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Since entity makes revisions trivial, we need to use the functionality. Beans are content and content should have revisions.
Comment | File | Size | Author |
---|---|---|---|
#17 | bean_revisions.patch | 28.86 KB | indytechcook |
#14 | bean_revisons.patch | 28.42 KB | indytechcook |
#13 | bean_revisons.patch | 38.06 KB | indytechcook |
#12 | bean_revisions.patch | 28.34 KB | indytechcook |
#11 | bean_revisions.patch | 23.62 KB | indytechcook |
Comments
Comment #1
indytechcook CreditAttribution: indytechcook commentedTagging with release blocker
Comment #2
indytechcook CreditAttribution: indytechcook commentedThis is dependent on #996696.
Comment #3
alexweber CreditAttribution: alexweber commentedFor the sake of clarity: #996696: Support revisions in Entity API
Comment #4
indytechcook CreditAttribution: indytechcook commentedWork is occurring in the bean_revisions branch. Here is the first pass at a patch (totally untested). This requires the patch from the entity API module
Comment #5
indytechcook CreditAttribution: indytechcook commentedIgnore previous patch. I did the diff backwards. Here is the correct one.
Comment #6
Kristen PolAfter the bean_revision table is created, don't you need to prepopulate it with a first round of revisions (where revision id = bean id)? When I created a patch for Field Collection awhile ago to support revisions, I did this. I had assumed it was necessary.
Also, you have a lot of logic for handling the revisions but I thought that the Entity API patch gives you a lot of it for "free"... I didn't try understanding what you were doing, though, so maybe it is all necessary.
Comment #7
Kristen PolPutting back to needs review for others to review.
Comment #8
indytechcook CreditAttribution: indytechcook commentedThanks. I've made a bunch of changes since last night. I'll push up a new patch today.
Comment #9
indytechcook CreditAttribution: indytechcook commentedHere is another patch. I'm still working off of the bean_revisions branch in git.
Left to do:
Comment #10
indytechcook CreditAttribution: indytechcook commented@Kristen The entity api module handles the saving and loading mostly. You still have to tell it when to save a new revision and which one to load. Some of the code is just overriding the load method with a one line change.
Comment #11
indytechcook CreditAttribution: indytechcook commentedUpdated Patch. Work is also in the bean_revisions patch.
Comment #12
indytechcook CreditAttribution: indytechcook commentedUpdated patch to add the ability to set the active revision. the bean_revisions branch is still up to date
Comment #13
indytechcook CreditAttribution: indytechcook commentedUpdated patch to match the new entity api patch #996696: Support revisions in Entity API
Comment #14
indytechcook CreditAttribution: indytechcook commentedMerged in code before rolling patch this time
Comment #15
indytechcook CreditAttribution: indytechcook commentedPatch needs to be rerolled against current entity API patch.
Comment #16
indytechcook CreditAttribution: indytechcook commentedThe patch has been committed to entity api. No more moving target! #996696: Support revisions in Entity API
Comment #17
indytechcook CreditAttribution: indytechcook commentedUPdated patch
Comment #18
indytechcook CreditAttribution: indytechcook commentedThis has been committed. Please open new issues.
Comment #20
muschpusch CreditAttribution: muschpusch commentedthis is giving me trouble: #1864564: duplicate entry 0 for VID in {bean}
Comment #20.0
muschpusch CreditAttribution: muschpusch commentedUpdated issue summary.