Remove old image module integration code [#1331736]

colorbox.module 7.2 at line 226 is using a constant 'IMAGE_ORIGINAL', but this isn't defined anywhere.

In Drupal 6.x this constant was defined in image.module, but it seems it has been gone in Drupal 7.x.

A quick fix could be a

define('IMAGE_ORIGINAL', '_original');

at top of the colorbox.module (there are already two other constant definitions).

Comments

Comment #1

Moloc CreditAttribution: Moloc commented 23 November 2011 at 18:02

There are some more issues like this one (not compatible to D7). There are no error messages, because the colorbox-settings don't allow to execute that lines of code.

I think, the origin is in colorbox.admin.inc in the function colorbox_admin_settings().
Does the code in the if-block "if (module_exists('image_old')) {" needs to be ported (if possible)? If not, it - and all dependencies like this issue - should be removed from code (or at least commented).
(I assume, that there is no module "image_old".)

Comment #2

lsolesen CreditAttribution: lsolesen commented 24 June 2012 at 22:02

Status:

Active

» Postponed (maintainer needs more info)

@Moloc Could you have a stab on a patch?

Comment #3

Moloc CreditAttribution: Moloc commented 24 June 2012 at 22:41

I don't know very much about the colorbox module. Maybe the maintainer knows, what this code should do?

Comment #4

frjo CreditAttribution: frjo commented 25 June 2012 at 06:29

Title:	Use of undefined constant IMAGE_ORIGINAL	» Remove old image module integration code
Version:	7.x-1.2	» 7.x-1.x-dev
Category:	bug	» task
Status:	Postponed (maintainer needs more info)	» Fixed