I found this code in core/themes/seven/style.css.

ol.task-list li.done {
  color: #393;
  background: transparent url(images/task-check.png) no-repeat 0 50%;
  color: green;
}
Files: 
CommentFileSizeAuthor
#1 clean_up_css_in_seven-theme-1328378-0.patch364 bytesChi
PASSED: [[SimpleTest]]: [MySQL] 33,748 pass(es).
[ View ]

Comments

Chi’s picture

Status:Active» Needs review
StatusFileSize
new364 bytes
PASSED: [[SimpleTest]]: [MySQL] 33,748 pass(es).
[ View ]

Status:Needs review» Needs work

The last submitted patch, clean_up_css_in_seven-theme-1328378-0.patch, failed testing.

Chi’s picture

Status:Needs work» Needs review
Chi’s picture

Issue tags:+needs backport to D7

Tagging for backport.

aspilicious’s picture

Status:Needs review» Reviewed & tested by the community

... I've seen these mistakes before...

note: #393 is kinda blue-ish

Jacine’s picture

Nice catch. :)

webchick’s picture

Status:Reviewed & tested by the community» Needs review

This is tagged for backport to D7. Can you explain (or better yet, demonstrate with screenshots) what the visual effects of this patch are? And if there are none, explain why?

Jacine’s picture

ol.task-list li.done {
  color: #393;
  background: transparent url(images/task-check.png) no-repeat 0 50%;
  color: green;
}

@webchick In the above code color: green is always used, because it comes last, so there's no visual change. #393 is also green (it's just a tad lighter). It's basically how CSS works. The browser renders the last property it understands. So, you could have 20 different colors defined and the last one will always win.

The person who coded this was probably just playing around with colors and forgot to remove the first one. There are no visual changes and it would have no effect on themes that have overridden it or anything like that, so it's totally safe for backport to D7.

Chi’s picture

No visual effects. It just makes code clear.

webchick’s picture

Status:Needs review» Fixed

LOL. OMG I'm rusty with CSS. Duh. Thanks for pointing that out.

Committed and pushed to 8.x and 7.x. Thanks. :)

Automatically closed -- issue fixed for 2 weeks with no activity.