When I check my watchdog logs, I always wonder if any of the searches didn't return any results. There is only one way to learn it, searching the same keywords again which creates another watchdog entry. Attached patch improves the watchdog message by adding number of search results and the elapsed time.

Patch also includes search result display improvements for the searcher. You can see the difference in the screenshot.


erdemkose’s picture

new19.96 KB

screenshot of watchdog entry

erdemkose’s picture

new29.65 KB

screenshot of search results

Please feel free to change the wordings in the patches.

erdemkose’s picture

new2.81 KB

right patch

Dublin Drupaller’s picture

nice one erdemkose. just thought I'd post a message to say your patch works with the search.module for Drupal 4.7.5 as well..


keith.smith’s picture

Status:Needs review» Needs work

# patch -p0 < detailed_search_log-2.patch
patching file modules/search/search.module
Hunk #1 succeeded at 928 (offset 28 lines).
Hunk #2 FAILED at 945.
patch unexpectedly ends in middle of line
Hunk #3 succeeded at 1285 with fuzz 1 (offset 3 lines).
1 out of 3 hunks FAILED -- saving rejects to file modules/search/search.module.rej

Pasqualle’s picture

Status:Needs work» Needs review
new2.71 KB

I really like this feature
rerolled with minor changes

1. there should be a problem with pager, I did not test that
2. the search statistics should be above the results, as it is displayed on picture #2

need some help from someone who better understand this theming stuff here

3. part of the watchdog message is stored as translated
'@result' => format_plural($pager_total_items[0], '1 match', '@count matches')

how should I correct this?

birdmanx35’s picture

Version:6.x-dev» 7.x-dev
Status:Needs review» Needs work

This is a feature change, and feature changes go to 7.x-dev.

Also, there are unresolved comments as per the last comment, so I'm setting this to CNW.

Jaza’s picture

Version:7.x-dev» 8.x-dev


mgifford’s picture

Issue summary:View changes

This still seems like a useful feature for Core.

jhodgdon’s picture

Sure... Right now my priority is to fix the bugs in search.module, so it is unlikely that this feature will be addressed. We would also have to consider the performance implications of this change.

jhodgdon’s picture

Version:8.0.x-dev» 8.1.x-dev

Since 8.0.x-beta1 has been released, our policy at this point is No feature requests until 8.1.x. See #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase?. Sorry, it's just too late for 8.0.x at this point, so even if we had a viable patch, the core committers would not commit it. So unless we decide this is a Task or a Bug (and I don't think it is), we'll have to delay it.