Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I'm not sure if this is a bug report or a feature request. But when you create Product Kits, they do not get a wish list button.
Comment | File | Size | Author |
---|---|---|---|
#15 | uc_wishlist-tie_in_product_kits-1327562-13-D6.patch | 3.59 KB | Sagar Ramgade |
#6 | uc_wishlist_1327562_6.patch | 7.68 KB | wizonesolutions |
Comments
Comment #1
storytellerjeff CreditAttribution: storytellerjeff commentedI'm experiencing the same behavior. Is there an easy way to allow this module to affect Product Kits as well?
Comment #2
torpy CreditAttribution: torpy commentedThis patch should enable wish lists for product kits.
Comment #3
torpy CreditAttribution: torpy commentedWhoops, that didn't actually fix anything, this should be the correct patch.
Comment #4
bancarddata CreditAttribution: bancarddata commentedThis gets the button on the page and will add the entire kit as a wishlist item, but does not seem to add the individual items of a kit set "as individual products", i.e. ones that explode when you add them to the cart. I am trying to figure out how to get that part to work, which will hopefully take into account any attributes for parts that are in the kit. Will chime back in if I figure it out. If anyone has any pointers, that would be appreciated.
Comment #4.0
bancarddata CreditAttribution: bancarddata commentedFix spelling
Comment #5
wizonesolutionsThe patch in #3 seems to also still add the product kit to the cart. Perhaps it's not removing a submit handler that it ought to be.
Comment #6
wizonesolutionsHere's a patch that fixes the behavior which sees the product kit simultaneously added to the cart. This is because Ubercart Product Kit handles this in
uc_product_kit_add_to_cart
; it's not supposed to do that, but that breaks things because we invoke that hook. I made a custom module invocation function for that hook which doesn't invoke it foruc_product_kit
.Not fully sure if this is working properly completely through checkout. Investigating that.
Comment #7
wizonesolutionsNah, it doesn't break checkout. It doesn't update the Have total properly but I don't think I'll be figuring that one out at this stage as quantity doesn't really apply to the site I'm working on.
So this should be good.
Comment #8
tparc CreditAttribution: tparc commentedCould this be committed to D7? Anyone willing to pick it up? Wish I had more experience.
Comment #9
jaykainthola CreditAttribution: jaykainthola commented@tparc, Kindly find the latest dev version of Drupal 7 version of the module. Its already implemented into module.
Thanks,
Jayendra Kumar
Comment #10
naveenvalechaFixed this is in the drupal 7 dev version.Needs to backport this request to drupal 6 version.
Thanks
Naveen Valecha
Comment #11
tparc CreditAttribution: tparc commentedThank you. Appears to be functioning well in D7. Have not tested all the way through checkout to see if 'wanted' quantity is reduced when item is purchased, but will try to do so.
Comment #12
berenddeboer CreditAttribution: berenddeboer commentedThe needs work status is for the D6 version. That's unlikely to happen. And review has been done by tparc. I propose we change the version back to 7.x, and close the issue.
Comment #13
naveenvalechaSurely sagar Ramgade would take this and backport this feature in d6 if he wants to.
Comment #15
Sagar Ramgade CreditAttribution: Sagar Ramgade commentedI had ported the D7 patch to D6, will commit it.
Comment #16
naveenvalechaSagar,
Great! A minor nutpick.
We should not use the prefix with this function name.
Comment #19
Sagar Ramgade CreditAttribution: Sagar Ramgade commentedThanks naveen yes understand it shouldn't be a private function, corrected in the next commit.
Comment #20
naveenvalechaok Remember it yourself. But do it before any release.Not a problem in dev branch.
Please change the status of the issue after fixing the issue.