Problem/Motivation

From #1315886: Clean up API docs for includes directory, files starting with A-C. Inline comments for several functions in common.inc are missing capitalization and/or periods.

Proposed resolution

Attatched patch cleans up these comments.

Remaining tasks

Patch is RTBC.

User interface changes

None.

API changes

None.

Files: 
CommentFileSizeAuthor
#6 1326472-POST-APOCALYPSE-comment-cleanup.patch8.4 KBxjm
PASSED: [[SimpleTest]]: [MySQL] 33,769 pass(es). View
#1 1326472-1-comment-cleanup.patch8.37 KBxjm
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1326472-1-comment-cleanup.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots. View

Comments

xjm’s picture

Status: Active » Needs review
Issue tags: +needs backport to D7
FileSize
8.37 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1326472-1-comment-cleanup.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots. View
xjm’s picture

Priority: Normal » Minor
Lars Toomre’s picture

Status: Needs review » Reviewed & tested by the community

All these changes look good and bring code closer to documentation standards.

catch’s picture

Issue tags: -needs backport to D7

#1: 1326472-1-comment-cleanup.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work
Issue tags: +needs backport to D7

The last submitted patch, 1326472-1-comment-cleanup.patch, failed testing.

xjm’s picture

Status: Needs work » Needs review
FileSize
8.4 KB
PASSED: [[SimpleTest]]: [MySQL] 33,769 pass(es). View
xjm’s picture

Status: Needs review » Reviewed & tested by the community

Just a reroll so it's still RTBC. :)

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x and 7.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nevets’s picture

Issue summary: View changes

Updated issue summary.