Current:

Optionally specify an alternative URL by which this content can be accessed. For example, type "about" when writing an about page. Use a relative path and don't add a trailing slash or the URL alias won't work.

Proposed:

The alternative URL for this content. For example, type "about" when creating an about page. Use a relative path without a trailing slash.
CommentFileSizeAuthor
#18 urlalias-desc-1326088-18.patch912 bytesPercy101
#17 reroll-1326088-17.patch1.96 KBArchisman
#15 after edit patch.module.JPG26.1 KBLord_of_Codes
#15 Rewrite-description-for-URL-alias-1681300-29.patch908 bytesLord_of_Codes
#14 rerollscreenshot.png16.29 KBsrikanthk16
#14 URLaliasDescriptionRerolled-1326088-14.patch0 bytessrikanthk16
#13 patch Screenshot.png4.6 KBro-29
#13 rewrite-decription-for-url-alias-2222963-5.patch908 bytesro-29
#6 1326088-urlalias-desc-rerolled-enter-4.patch909 bytesmallezie
#4 1326088-urlalias-desc-rerolled-enter.4.patch909 bytesmallezie
#4 beforepatch.png28.96 KBmallezie
#4 after.png28.53 KBmallezie
#1 1326088-urlalias-desc.patch886 bytesyoroy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yoroy’s picture

yoroy CreditAttribution: yoroy commented
Status: Active » Needs review
FileSize
1326088-urlalias-desc.patch886 bytes

Related: [1325976]

Trying a patch…

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Status: Needs review » Needs work 
+++ b/modules/path/path.moduleundefined
@@ -136,7 +136,7 @@ function path_form_node_form_alter(&$form, $form_state) {
+		'#description' => t('The alternative URL for this content. Use a relative path without a trailing slash. For example, type "about" for the about page.'),

Oops, some goofy indentation here.

The text change seems like an improvement to me. Except, maybe we should replace the word "type" with "enter"? We don't care whether they enter it by typing or not.

Two good novice tasks here are:

  1. Rerolling the patch with the suggested changes, using the updated directory structure for Drupal 8.x
  2. Posting "before" and "after" screenshots of this text change.

Note that the Drupal 8.x patch will need to be rerolled, because the core directory structure for Drupal 8 has now changed. (For more information, see #22336: Move all core Drupal files under a /core folder to improve usability and upgrades). When the patch has been rerolled, please set the issue back to "Needs Review."

If you need help rerolling this patch, you can come to core office hours or ask in #drupal-gitsupport on IRC.

yoroy’s picture

yoroy CreditAttribution: yoroy commented

Agreed on using 'enter'. Hope to see someone take this on and re-roll :)

mallezie’s picture

mallezie
Primary language Dutch
Location Loenhout
CreditAttribution: mallezie commented
FileSize
after.png28.53 KB
beforepatch.png28.96 KB
1326088-urlalias-desc-rerolled-enter.4.patch909 bytes

I rerolled the patch.
Corrected the indentation and changed "type" with "enter".

Before screenshot
Before patch
After screenshot
After patch
And patch attached

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Status: Needs work » Needs review
Issue tags: -Novice

Thanks! Setting NR so testbot picks it up.

mallezie’s picture

mallezie
Primary language Dutch
Location Loenhout
CreditAttribution: mallezie commented
Issue tags: +Novice
FileSize
1326088-urlalias-desc-rerolled-enter-4.patch909 bytes

If im not mistaken test bots has troubles with dots, so renaming patch and rerolling.
and i forget to set to needs review.

kathyh’s picture

kathyh CreditAttribution: kathyh commented
Status: Needs review » Reviewed & tested by the community

Verified patch applied cleanly and the new text is seen when new content is added.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Issue tags: +String freeze

#7: Well, in addition to verifying that the patch does what it says, we also need to decide whether the change should be made and whether the proposed text is what we want. Typically we want consensus from a few people for these sorts of changes.

In this case, though, I think this is a clear text improvement and I'd agree this is RTBC.

kathyh’s picture

kathyh CreditAttribution: kathyh commented
Status: Reviewed & tested by the community » Needs review
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Status: Needs review » Reviewed & tested by the community

Nah, this is good. :) I was just clarifying the usual practice for RTBCing patches that introduce changes, based on your comment text. (yoroy is one of the UX topic maintainers.)

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Looks good. Committed/pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

ro-29’s picture

ro-29 CreditAttribution: ro-29 commented
Title: Rewrite description for URL alias on node/add/* » Rewrite description for URL alias on node/add/* Patch
Issue summary: View changes
FileSize
rewrite-decription-for-url-alias-2222963-5.patch908 bytes
patch Screenshot.png4.6 KB
srikanthk16’s picture

srikanthk16 CreditAttribution: srikanthk16 commented
FileSize
URLaliasDescriptionRerolled-1326088-14.patch0 bytes
rerollscreenshot.png16.29 KB

#14 rerolled url alias description

Lord_of_Codes’s picture

Lord_of_Codes CreditAttribution: Lord_of_Codes commented
FileSize
Rewrite-description-for-URL-alias-1681300-29.patch908 bytes
after edit patch.module.JPG26.1 KB

Submission of patch for Google-Code-In.

Lord_of_Codes’s picture

Lord_of_Codes CreditAttribution: Lord_of_Codes commented
Archisman’s picture

Archisman CreditAttribution: Archisman commented
FileSize
reroll-1326088-17.patch1.96 KB

re-rolled the patch for gsoc ladder

Percy101’s picture

Percy101 CreditAttribution: Percy101 as a volunteer commented
FileSize
urlalias-desc-1326088-18.patch912 bytes